The method getActiveItems() of FacetApiAdapter class has wrong doc comment for input argument $facet.

For now it is 

   * @param array|string $facet
   *   Either the facet definition as returned by facetapi_facet_load() or the
   *   machine readable name of the facet.

but method accepts only array values.

CommentFileSizeAuthor
#2 documentation_issue-2563117-2.patch466 bytespravin ajaaz

Comments

undertext created an issue. See original summary.

pravin ajaaz’s picture

pravin ajaaz commented
Status: Active » Needs review
StatusFileSize
new documentation_issue-2563117-2.patch466 bytes

A patch to fix it.

Sonal.Sangale’s picture

Sonal.Sangale commented
Assigned: Unassigned » Sonal.Sangale
Status: Needs review » Reviewed & tested by the community
pravin ajaaz’s picture

pravin ajaaz commented

  • eugene.ilyin committed 30fb518 on 7.x-1.x 
    Issue #2563117 by undertext: Documentation issue with getActiveItems()...
eugene.ilyin’s picture

eugene.ilyin commented

Patch is wrong. Applied, but with corrections.

eugene.ilyin’s picture

eugene.ilyin commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

remydenton’s picture

remydenton commented
Related issues: +#2867867: Allow getActiveItems() method to accept argument as either a string or an array

Follow-up issue: https://www.drupal.org/node/2867867