Problem/Motivation

Over the past few months, the SmartCache issue/patch has collected a bunch of smaller fixes that don't really make sense to commit separately (usually because they only cause test failures with SmartCache applied, or because of small bugs that are only made apparent by SmartCache). But, now that that issue was raised to critical and is approaching RTBC, it was proposed by @effulgentsia that it'd be better to still commit them separately, in this issue.

Proposed resolution

Fix those small bugs, and have test coverage where it makes sense.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because lots of small bugs that are blocking SmartCache.
Issue priority Major because blocking a critical.
Disruption Zero disruption.
CommentFileSizeAuthor
#2 2562757-2.patch10.81 KBwim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2562757-2.patch10.81 KB
fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

RTBC, that all makes a lot of sense!

effulgentsia’s picture

effulgentsia commented
Priority: Major » Critical

Nice! Promoting to Critical since it's a hard blocker for a critical.

dawehner’s picture

dawehner
Primary language German
commented

+1

effulgentsia queued 2: 2562757-2.patch for re-testing.

  • effulgentsia committed ae7ec6c on 8.0.x 
    Issue #2562757 by Wim Leers: Various small cacheability fixes that are...
effulgentsia’s picture

effulgentsia commented
Status: Reviewed & tested by the community » Fixed

Pushed to 8.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.