Problem/Motivation

Tests are currently failing because the required schema for langcode is missing for several types in the name.settings schema. After that's fixed, the default config doesn't match the schema and needs an update for some values.

Proposed resolution

Switch the type from mapping to config_object (a schema with a mapping and the langcode, nothing else) and update the default config where necessary.

Remaining tasks

Review patch, commit it.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#5 interdiff_2-5.txt705 bytesLKS90
#5 fix_schema_errors_and-2562567-5.patch3.42 KBLKS90
#2 fix_schema_errors_and-2562567-2.patch3.46 KBLKS90

Comments

LKS90 created an issue. See original summary.

LKS90’s picture

LKS90 commented
Status: Active » Needs review
StatusFileSize
new fix_schema_errors_and-2562567-2.patch3.46 KB

Here is the patch that fixes all the issues.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs review » Reviewed & tested by the community

Looks good.

webflo’s picture

webflo commented
Status: Reviewed & tested by the community » Needs work 
+++ b/config/schema/name.schema.yml
@@ -50,11 +50,11 @@ name.settings:
     user_preferred:
-      type: string
+      type: boolean
       label: 'User preferred'

The user_preferred settings needs to be a string because we store the field name is this config property.

Take a look at name_field_config_create and name_field_config_delete.

I think we should change the default value to empty string instead.

LKS90’s picture

LKS90 commented
Status: Needs work » Needs review
StatusFileSize
new fix_schema_errors_and-2562567-5.patch3.42 KB
new interdiff_2-5.txt705 bytes

Here is the patch without the wrong change. Now there are some test fails (which I vaguely remember), I don't think they are related, but you will probably know that :). I used an empty string as the default configuration for the user_preferred setting, I guess one of the two functions will be called afterwards to set it correctly.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs review » Reviewed & tested by the community

I tested locally with protected $strictConfigSchema = FALSE; and fails are not related to the schema. So the patch is fine.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: fix_schema_errors_and-2562567-5.patch, failed testing.

  • webflo committed 72157f6 on 8.x-1.x authored by LKS90 
    Issue #2562567 by LKS90: Fix schema errors and update default config to...
giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.