Provision_Config_Apache_Site doesn't pass all the info to hook_provision_apache_vhost_config

I am trying to use hook_provision_provision_apache_vhost_config() to write more server variables to my apache/nginx configs.

The problem is that I don't have access to all of the available information in the site context.

I have fixed this by adding $this to the hook invocation.

So now, Provision/Config/Apache/Site.php looks like this:

/** 
 * Apache site level config class. Virtual host.
 */
class Provision_Config_Apache_Site extends Provision_Config_Http_Site {
  function process() {
    parent::process();
    $this->data['extra_config'] = "# Extra configuration from modules:\n";
    $this->data['extra_config'] .= join("\n", drush_command_invoke_all('provision_apache_vhost_config', $this->uri, $this->data, $this));
  }
}

We could remove the $this->uri and $this->data, but this would break backwards compatibility with any existing hook implementations.

This is a problem for a lot of hooks actually...

• hook_provision_drupal_config
• drush_hook_provision_apache_server_config
• drush_hook_provision_apache_dir_config
• drush_hook_provision_apache_vhost_config
• drush_hook_provision_nginx_server_config
• drush_hook_provision_nginx_dir_config
• drush_hook_provision_nginx_vhost_config

I propose that in the current release branch we add $this as an additional parameter to all of the hook invocations so we don't break backwards compatibiltiy, and we revisit this in future releases.

I am going to push a branch soon with these proposed changes.

Thoughts?

Thanks!