The docs for \Drupal\Core\Field\Plugin\Field\FieldFormatter\EntityReferenceEntityFormatter references that an entity manager should be provided, but it is incorrect. Instead \Drupal::entityManager() is used in the code instead of it being injected. We also use the deprecated entity_view() function.

CommentFileSizeAuthor
#5 2562099-5.patch4.6 KBamateescu
#3 2562099-fix-entityreferenceentityformatter.patch4.06 KBdave reid
#2 2562099-fix-entityreferenceentityformatter.patch4.35 KBdave reid

Comments

Dave Reid created an issue. See original summary.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2562099-fix-entityreferenceentityformatter.patch4.35 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 2562099-fix-entityreferenceentityformatter.patch4.06 KB
amateescu’s picture

amateescu commented
Component: field system » entity_reference.module
Status: Needs review » Needs work 
  1. +++ b/core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/EntityReferenceEntityFormatter.php
@@ -95,7 +105,7 @@ public static function defaultSettings() {
+      '#options' => $this->entityManager->getViewModeOptions($this->getFieldSetting('target_type')),

    We should use the 'entity_display.repository' service now. 

  2. +++ b/core/lib/Drupal/Core/Field/Plugin/Field/FieldFormatter/EntityReferenceEntityFormatter.php
@@ -134,7 +144,8 @@ public function viewElements(FieldItemListInterface $items, $langcode) {
+        $view_builder = $this->entityManager->getViewBuilder($entity->getEntityTypeId());

    And the 'entity_type.manager' service here.

amateescu’s picture

amateescu commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 2562099-5.patch4.6 KB

Fixed the two minor review points from above.. the patch didn't apply anymore so there's no interdiff.

The changes are very small so I'm setting this straight to RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Reviewed & tested by the community » Fixed

Due to the constructor changes this needs to go into a minor release only. Committed/pushed to 8.1.x, thanks!

  • catch committed 6cbd448 on 
    Issue #2562099 by Dave Reid, amateescu: EntityReferenceEntityFormatter...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.