Problem/Motivation

The d7_field_formatter_settings migration does not sanitize the formatter settings coming from the source database. At the very least, it needs to be an array before the formatter settings are saved, but occasionally the settings are NULL in the source database, and this gets passed through to the destination plugin, causing an "unsupported operand types" fatal.

Proposed Resolution

Use the field_formatter_default_settings process plugin, which normalizes the formatter settings before they're saved.

Remaining Tasks

Patch, review, commit.

API/UI Changes

None.

CommentFileSizeAuthor
#3 interdiff-2562089-3.txt509 bytesphenaproxima
#3 2562089-3.patch3.43 KBphenaproxima
#3 2562089-3-FAIL.patch2.77 KBphenaproxima
#2 2562089-2.patch665 bytesphenaproxima
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

phenaproxima created an issue. See original summary.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Active » Needs review
Issue tags: +Needs tests
FileSize
2562089-2.patch665 bytes

Initial patch.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Issue tags: -Needs tests
FileSize
2562089-3-FAIL.patch2.77 KB
2562089-3.patch3.43 KB
interdiff-2562089-3.txt509 bytes

Now with a fail patch, a happy patch, and an interdiff. Boom!

The last submitted patch, 3: 2562089-3-FAIL.patch, failed testing.

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul at APQC commented
Status: Needs review » Reviewed & tested by the community

looks good to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 1ce074c on 8.0.x 
    Issue #2562089 by phenaproxima: d7_field_formatter_settings migration...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.