The search_api modules were recently updated with new releases!

search_api 1.17:

https://www.drupal.org/node/2687091

search_api_solr 1.10:

https://www.drupal.org/node/2687097

search_api_db 1.5:

https://www.drupal.org/project/search_api_db

This will need manual testing of search and the update process on existing sites that SOLR, and a run through the automated tests.

Comments

dsnopek created an issue. See original summary.

temkin’s picture

There was a pretty bad issue in Search API 1.15 that made unwanted content appear in search results. We've just discovered it today and had to upgrade to Search API 1.16. Hope it will get to the next version of Panopoly. Let me know if I can help in any way to make this happen. Thanks!

dsnopek’s picture

Status: Active » Needs review
StatusFileSize
new1.02 KB

Here's a patch so we can run the tests on Travis-CI!

EDIT: Here's the build: https://travis-ci.org/panopoly/panopoly/builds/88188656

cboyden’s picture

StatusFileSize
new1.02 KB
new433 bytes

The build for the initial patch failed because the patch for #2436341: Problem with search_api_db_update_7104 + updated features failed to apply.

Also, there is a wrinkle in the new version of Search API that will affect the search.feature test. Immediate indexing is not triggered for content owned by Anonymous. (It's not clear to me whether that's a bug or a feature.) The result is that the scenario that tests for indexing of panelized content will fail because there's no cron run in that scenario. The scenario is effectively testing both immediate indexing and indexing of panelized content.

For now one solution would be to update search.feature to run cron after saving the page with the widget, and then add another scenario to test immediate indexing.

The scenario could click through the UI to create a page while logged in as a privileged user. Or, the custom "Given I am viewing a landing page" step could be modified to assign authorship to the logged-in user for the scenario. It's probably not used in any scenario that doesn't have a logged-in user at the time the page is created.

cboyden’s picture

Here's a patch for panopoly_test that runs cron after adding the widget and adds a separate test for immediate indexing.

cboyden’s picture

Travis build with these two patches: https://travis-ci.org/cboyden/panopoly/builds/107281260

cboyden’s picture

Automated tests are passing, but this still needs manual testing with Solr.

dsnopek’s picture

Title: Update to search_api 1.16, search_api_solr 1.9 and search_api_db 1.5 » Update search_api to 1.17, search_api_db to 1.5, search_api_solr to 1.10
Issue summary: View changes
StatusFileSize
new1.02 KB
dsnopek’s picture

dsnopek’s picture

The automated tests passed! Manual testing with SOLR would be great, but I think I might commit without it. The latest releases have been out since March 14 (over a month) and we can't delay forever...

  • dsnopek committed bb38a57 on 7.x-1.x
    Update Panopoly Search and Test for Issue #2561737 by cboyden, mpotter:...
dsnopek’s picture

Status: Needs review » Fixed

Committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.