This is a follow-on to #2477641: One-time login link failure messages are misleading because they are not marked as errors with an additional D8 fix that was unearthed during back-porting the patch to D7.
If a user clicks on a "one time login link" that has expired, is invalid, or that cannot be processed because another user is already signed in, the errors displayed are shown as standard messages (e.g. appearing in green with a checkmark, depending on the theme), signifying success rather than failure.
If a one-time login link cannot be used (for any reason), this should be flagged as either a 'warning' or an 'error' instead.
Need somebody to push into core
Users will be presented with an 'error' or 'warning' message instead of a 'success' message if a one-time login link is unsuccessful.
None.
| Issue category | Task because this does not impair functionality and is little more than a minor UX repair |
|---|---|
| Issue priority | Minor |
| Unfrozen changes | Unfrozen because it only changes the semantics of the messages displayed, and should not cause any compatability issues |
| Prioritized changes | The main goal of this issue is usability. |
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | drupal-2561685-3-D8.patch | 1.25 KB | markpavlitski |
Comments
Comment #2
markpavlitski commentedComment #3
markpavlitski commentedThe attached D8 patch addresses the two additional messages fixed in #2477641: One-time login link failure messages are misleading because they are not marked as errors, comments #37 and #40.
Comment #5
sgurlt commentedChecking this now.
Comment #6
sgurlt commentedWorks as expected :)
Comment #7
markpavlitski commentedThanks :)
Would be good to see this one get in!
Comment #8
alexpott@sg88 screenshots would have been nice to prove that you've tested it - if you had done that I would have given you commit credit too.
Committed 136b01c and pushed to 8.0.x. Thanks!
Comment #11
markpavlitski commentedAlready committed. Marking back as fixed.