Problem/Motivation

#507488: Convert page elements (local tasks, actions) into blocks landed and turns tasks/actions into blocks. This breaks a couple of Tests, like ProcessingWebTest, RelationWebTest, EntityWebTest and CollectWebTest, because those rely on some tasks/actions to be displayed in the UI.

Proposed resolution

Add the tasks/actions blocks to the tests where it's necessary.

Remaining tasks

Discuss, review, commit.

User interface changes

None

API changes

None

Data model changes

None

Comments

LKS90 created an issue. See original summary.

LKS90’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new2.86 KB

Here is a patch that does exactly what I described in the issue. The tests passed locall, maybe there are more tests that need updating, I looked for tests that were clicking/asserting links and only found the four mentioned in the issue description.

mbovan’s picture

Small changes here... Added blocks in CollectClientWebTest, removed some unused ones, moved them to setUp() where needed.

LKS90’s picture

Status: Needs review » Reviewed & tested by the community

Nice, reviewed the new patch and it looks good. I think that covers all tests now.

berdir’s picture

Comitted, thanks.

  • Berdir committed 774f613 on 8.x-1.x authored by mbovan
    Issue #2561631 by mbovan, LKS90: Update tests to add local tasks/actions...

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: update_tests_to_add-2561631-3.patch, failed testing.

berdir’s picture

Status: Needs work » Fixed

The last submitted patch, 2: update_tests_to_add-2561631-2.patch, failed testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.