"Text on demand" for "input required" exposed form plugin is not displayed

Well I was also wondering about that. The view in the test had no result, so it was only "needed" to test for the string there :)

We could also rewrite the test to actually have results...

Considering this is a text that is used to convey to the user that an exposed filter is required, I am a bit unclear about whether to set it to true by default (which would mean the text will display even if the view has no results).

This is something that has been in views since #535868: Exposed forms as plugins, so I'll see about having a look at that issue and installing an old version of views to find out how this used to behave on no results.

From digging into the original D6 code it looks like passing along the empty=TRUE option is indeed needed. That old code had the 1 of the 2 bugs this patch found (back then it was indeed $options['content'] and $options['format']), but there was no way to make it work because empty option was not set back then either, so it this 'feature' may have been broken for 6+ years? :)

Basically in the query() method the InputRequired exposed form plugin forces an empty result if no exposed filters are applied.

The "on demand text" (that used to have as default "Select any filter and click on Apply to see results") will only display if no exposed filters are applied (see InputRequired::preRender()).

But the views area text handler will only render something if either the empty option is enabled ("Display even if view has no result") or if the result is not empty. As the result is always empty, and the empty option is disabled, the text never shows. So I believe we need to set this option here.

I'd also be fine with removing the whole "on demand text" feature, if it never even worked?

updating IS

Hmm if we appended we'd need to worry about separators / wrapping them in different HTML elements, and in this case the view isn't actually empty, it's just "fake empty" (the input required plugin does this). So the empty message may or may not be correct -- if applicable, it will currently show up as soon as an exposed filter is selected and the view is still empty. So I think we're fine here and in any case this sounds a bit out of scope for this issue. May be follow-up material as this whole feature is confusing, I don't think "Text on demand" is a thing in English anyway? :P

And screenshots:

1. +++ b/core/modules/views/src/Plugin/views/exposed_form/InputRequired.php
   @@ -81,14 +84,22 @@ public function preRender($values) {
   +        // We need to set the "Display even if view has no result" option to
   +        // to TRUE as the input required exposed form plugin will always force
   

   "to to", can be fixed on commit

2. +++ b/core/modules/views/src/Tests/Plugin/ExposedFormTest.php
   @@ -194,6 +194,31 @@ public function testInputRequired() {
   +    // Ensure that the "on demand text" is not displayed when an exposed filters
   

   s/filters/filter/