Problem/Motivation

https://www.drupal.org/pift-ci-job/25521

fail: [Other] Line 234 of core/modules/system/src/Tests/System/UncaughtExceptionTest.php:
Raw "PDOException" found

This might be related to #2561121: Installer fails on postgresql due to uncaught exception.

Proposed resolution

@todo

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 2561133.5.patch988 bytesalexpott
#3 2561133.3.patch573 bytesalexpott

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Issue summary: View changes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2561133.3.patch573 bytes

This was broken by the changes made for #2548725: Fix regression to menu serialization in upgrade path that causes thousands of errors in PostgreSQL.

We can slightly change the assertions to fit both MySQL and Postgres

dawehner’s picture

dawehner
Primary language German
commented

Mh, are you convinced of that change?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 2561133.5.patch988 bytes

Discussed with @dawehner in IRC reverting #2548725-28: Fix regression to menu serialization in upgrade path that causes thousands of errors in PostgreSQL. This passes on both mysql and psql.

I think this is the better change because I'm not sure what the early patch fixed.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

I think this is the better change because I'm not sure what the early patch fixed.

Well, yeah the earlier patch tried to fix some exception message in the installer configuration. I think we should have a dedicated look at that, which I guess will happen in #2561121: Installer fails on postgresql due to uncaught exception

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

So this results in more postgres failures, not less, but since we get similar postges in failures in HEAD anyway (and there's a chance it's an infra issue), agreed let's tackle them all in #2561121: Installer fails on postgresql due to uncaught exception.

However I did a straight revert commit of the commit hash rather than commit the patch here.

catch’s picture

catch
he/him
Primary language English
commented

http://drupalcode.org/project/drupal.git/commit/447a049

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.