I have been trawling through Bartik's code as part of another issue and noticed that Bartik uses the following selectors to style forums within forum lists:
However in the markup and template within Classy the forum's name class is just declared as .name when is should be .forum__name.
I do not want to adjust the selector in Bartik to be non-BEM and currently the styles look bad as the description is currently printing bigger than the name so we should fix the class in Classy.
Add the .forum__name class to Classy's template to replace .name . Check that no other CSS exists styles the forum name with the current selector in HEAD.
none
none
none
| Issue category | Bug because markup in Classy is currently causing visual issues in Bartik. |
|---|---|
| Issue priority | Not critical because the forum functions fine. |
| Unfrozen changes | Unfrozen because it only changes markup |
| Prioritized changes | The main goal of this issue is to visually fix the styles of a component in Core. |
| Disruption | Non-disruptive it fixes a visual bug |
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | class-forum__name.png | 19.15 KB | thamas |
| #5 | class-name.png | 18.87 KB | thamas |
| #3 | replace_a_class_in-2560231-3.patch | 825 bytes | emma.maria |
| #3 | Screen Shot 2015-08-31 at 10.16.45.png | 22.92 KB | emma.maria |
| #3 | Screen Shot 2015-08-31 at 10.16.54.png | 69.46 KB | emma.maria |
Comments
Comment #2
emma.mariaComment #3
emma.mariaPatch + screenshots...
Markup and screenshot of forum in Bartik
Comment #4
emma.mariaAlso just to add there is no CSS that themes the forum with the current class of .name anywhere in Core.
Comment #5
thamasPatch applies flawlessly, class is changing and also the related font-size.
Comment #6
emma.mariaThanks @thamas for the review :-)
Comment #7
webchickCommitted and pushed to 8.0.x. Thanks!