Problem/Motivation

I have been trawling through Bartik's code as part of another issue and noticed that Bartik uses the following selectors to style forums within forum lists:
 

 
However in the markup and template within Classy the forum's name class is just declared as .name when is should be .forum__name.
 

 
I do not want to adjust the selector in Bartik to be non-BEM and currently the styles look bad as the description is currently printing bigger than the name so we should fix the class in Classy.

Proposed resolution

Add the .forum__name class to Classy's template to replace .name . Check that no other CSS exists styles the forum name with the current selector in HEAD.

Remaining tasks

User interface changes

none

API changes

none

Data model changes

none

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because markup in Classy is currently causing visual issues in Bartik.
Issue priority Not critical because the forum functions fine.
Unfrozen changes Unfrozen because it only changes markup
Prioritized changes The main goal of this issue is to visually fix the styles of a component in Core.
Disruption Non-disruptive it fixes a visual bug

Comments

emma.maria created an issue. See original summary.

emma.maria’s picture

Title: Replace an class in forum-list.html.twig with a BEM class. » Replace a class in forum-list.html.twig with a BEM class.
emma.maria’s picture

Issue summary: View changes
Status: Active » Needs review
FileSize
69.46 KB
22.92 KB
825 bytes
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 110,841 pass(es). View

Patch + screenshots...

Markup and screenshot of forum in Bartik
 

 

emma.maria’s picture

Also just to add there is no CSS that themes the forum with the current class of .name anywhere in Core.

thamas’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
18.87 KB
19.15 KB

Patch applies flawlessly, class is changing and also the related font-size.

emma.maria’s picture

Thanks @thamas for the review :-)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 2b41436 on 8.0.x
    Issue #2560231 by emma.maria, thamas: Replace a class in forum-list.html...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.