Faster DOM rendering

** There're few errors I noticed in unpatch version , please compare them side by side :)

CommentFileSizeAuthor
#9 toolbar.png17.65 KBandypost
toolbar-improve.patch3.7 KBdroplet

Comments

droplet created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » nod_

We definitely need @nod_'s sign-off on this.

nod_’s picture

nod_
Primary language French
Location Lille
commented

haven't tested yet but totally for it

tr’s picture

tr commented

Would this have the potential to fix scrolling to fragments like /admin/modules#module-update, which currently doesn't work because the height of the toolbar isn't accounted for?

nod_’s picture

nod_
Primary language French
Location Lille
commented

No, it's another issue

nod_’s picture

nod_
Primary language French
Location Lille
commented

See #1870006: HTML5 validation with table sticky header is misaligned over the toolbar

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Needs work

Umm so it is a bit faster but the loading is not consistent anymore. It's jumping around more on bartik than seven. At least not it's jumping around the same and in the same manner on every page.

andrewmacpherson’s picture

andrewmacpherson commented
Version: 8.0.x-dev » 8.1.x-dev
andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
Issue tags: -Needs manual testing
StatusFileSize
new toolbar.png17.65 KB

With patch attached

droplet’s picture

droplet commented
Status: Needs work » Closed (won't fix)

Must be some new updates.

I've merged them into #2542050: Toolbar implementation creates super annoying re-rendering.