Problem/Motivation

Child issue of #2558247: Remove rebuildAll() and module install from UpdatePathTestBase

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 interdiff.txt813 bytesdawehner
#8 2559637-8.patch2.21 KBdawehner
#5 2559637-4.patch3.01 KBdawehner
#4 interdiff.txt1.33 KBdawehner
#4 interdiff.txt1.33 KBdawehner
#4 NestedRouteProvider.php_.txt2.42 KBdawehner
#2 2559637-2.patch4.1 KBdawehner

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
Parent issue: » #2558247: Remove rebuildAll() and module install from UpdatePathTestBase
StatusFileSize
new 2559637-2.patch4.1 KB

Here is the patch.

dawehner’s picture

dawehner
Primary language German
commented
Title: Don't rely on a working router on /update.php » Don't rely on a working router on /update.php for URL generation
dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new NestedRouteProvider.php_.txt2.42 KB
new interdiff.txt1.33 KB
new interdiff.txt1.33 KB

For future reference ... we here is a nested route provider.

For now it seems to be not needed at all to override the router ... as we made a bug while doing it.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2559637-4.patch3.01 KB

And here the actual patch

dawehner’s picture

dawehner
Primary language German
commented

It should have been '@router.route_provider' not 'router.route_provider'

pwolanin’s picture

pwolanin commented 
+use Drupal\system\Tests\Routing\MockRouteProvider;

Added but not used?

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2559637-8.patch2.21 KB
new interdiff.txt813 bytes

Added but not used?

Right, no longer now.

catch’s picture

catch
he/him
Primary language English
commented

The patch is green, but on #2558247: Remove rebuildAll() and module install from UpdatePathTestBase I ran into many more issues with template_preprocesss_html(), system_js_settings_alter() and similar - mostly checking for the front page and similar.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Closed (duplicate)

Talked with catch, this is a pointless issue: #2558247: Remove rebuildAll() and module install from UpdatePathTestBase is where we will meet again.