In order to make #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests approachable, we need to break it up into smaller chunks. This issue address !placeholder in the Language module
File Bounds:
core/modules/language/*
See #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand for complete motivation on removal of !placeholder
Replace !placeholder with @placeholder in the Language module. See File bounds for scope.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | ScreenShot-2559475-7-2.png | 36.26 KB | sutharsan |
| #8 | ScreenShot-2559475-7-1.png | 63.37 KB | sutharsan |
| #7 | replace_placeholder-2559475-7.patch | 18.04 KB | sutharsan |
| #3 | replace_placeholder-2559475-3.patch | 19.44 KB | joelpittet |
Comments
Comment #2
justachris commentedComment #3
joelpittetComment #4
mile23Looked for !placeholders in strings using NetBeans and my eyes. (!? as a wildcard expression)
Couldn't find any.
Comment #5
justachris commentedThanks @Mile23 for the code review.
Can we add manual testing for these? We need make sure there aren't any differences in the output, most commonly with double escaping.
Comment #6
sutharsan commentedWorking on manual test.
Comment #7
sutharsan commentedRerolled patch #3.
The changes in NegotiationConfigureForm::configureFormTable() have been removed as the proper placeholder is already in place.
Comment #8
sutharsan commentedManually tested the patch:
Language help page and Language negotiation help text only contains placeholders containing a URL. All links tested, they work.
Site's default language (@language): See screenshots. Using © as special character.
Language switcher (@type): Can not activate this string in the interface.
@name field is required.: Is part of test code.
Comment #9
sutharsan commentedComment #10
justachris commentedPostponed on determining plan in parent #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand and then analyzing whether this individual issue still makes sense.
@Sutharsan: Again, very sorry that this was not postponed earlier. Thank you for manually reviewing that patch, please keep an eye on #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand, as I'm sure resulting issues and patches will have plenty to review.
Comment #11
justachris commentedClosing this, splitting by module was not the ideal approach to removing !placeholder. Marking as duplicate of #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand, since the chosen approach is / will be outlined there, please refer to it for any additional action.
Comment #12
sutharsan commentedPatch now included in #2506445-140: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.
Comment #13
xjm