Replace !placeholder with @placeholder in Update module

$ git apply replace_placeholder-2559469-2.patch 
error: patch failed: core/modules/update/update.module:72
error: core/modules/update/update.module: patch does not apply

Here is updated patch.

Looked for other !placeholders in strings using NetBeans and my eyes. (!? as a wildcard expression)

Couldn't find any.

+++ b/core/modules/update/update.module
@@ -441,7 +441,7 @@ function update_fetch_data_finished($success, $results) {
-  $message['subject'] .= t('New release(s) available for !site_name', array('!site_name' => \Drupal::config('system.site')->get('name')), array('langcode' => $langcode));
+  $message['subject'] .= t('New release(s) available for @site_name', array('@site_name' => \Drupal::config('system.site')->get('name')), array('langcode' => $langcode));

@webchick has pointed that this is incorrect... It'll result in emails becoming

Welcome to Webchick"s Crazy Drupal Site

hi,
i configured my site name to "izus's website"
i applied the patch
i enabled update module and run cron
the $message['subject'] contains: New release(s) available for izus's website

with !site_name back again it's now: New release(s) available for izus's website

i also deleted the modifications in hook_help as there is already an issue for that #2560783: Replace !placeholder with :placeholder for URLs in hook_help() implementations

+++ b/core/modules/update/update.module
@@ -451,10 +451,10 @@ function update_mail($key, &$message, $params) {
-    $message['body'][] = t('Your site is currently configured to send these emails when any updates are available. To get notified only for security updates, !url.', array('!url' => $settings_url));
+    $message['body'][] = t('Your site is currently configured to send these emails when any updates are available. To get notified only for security updates, @url.', array('@url' => $settings_url));
...
-    $message['body'][] = t('Your site is currently configured to send these emails only when security updates are available. To get notified for any available updates, !url.', array('!url' => $settings_url));
+    $message['body'][] = t('Your site is currently configured to send these emails only when security updates are available. To get notified for any available updates, @url.', array('@url' => $settings_url));

Not sure this one is correct either since it is an email.

Also #7 seems to be missing most of the "correct" changes from #4

Hi,
Thanks for the review, here is a new patch.

- it addresses #8 by puting back !url
- the #9 is due to deleting the modifications in hook_help as there is a special issue for those (mentionned in #7) #2560783: Replace !placeholder with :placeholder for URLs in hook_help() implementations

Thanks

Postponed on determining plan in parent #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand and then analyzing whether this issue still makes sense.

Closing this, splitting by module was not the ideal approach to removing !placeholder. Marking as duplicate of #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand, since the chosen approach is / will be outlined there, please refer to it for any additional action.

Patch now included in #2506445-140: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.