Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
comment.module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Aug 2015 at 18:41 UTC
Updated:
27 Sep 2015 at 16:02 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
justachris commentedComment #3
joelpittetComment #4
justachris commentedWe missed a couple of replacements:
Comment #5
izus commentedhi,
i deleted the part of hook_help as there is one mega patch to fix is in #2560783: Replace !placeholder with :placeholder for URLs in hook_help() implementations
i fixed the missing parts mentioned in #4
Thanks
Comment #6
justachris commentedWell that simplifies manual testing a bit. The only location that is not a test is in the meta information on a comment display. Since this specific text is visually hidden, including only a grab of the source, which matches exactly before the patch:

Comment #4 has been addressed and I don't see any other occurrences of !placeholder; all changes are in the scope of this module.
Updating IS to indicate separation of hook_help() from this issue. Good to go.
Comment #7
justachris commentedWow, that last image was too scaled to be legible. Trying again:

Still RTBC
Comment #8
catchPostponed on #2558791: "!"-prefixed tokens should Xss::filterAdmin() but not affect safeness.
Comment #9
justachris commentedClosing this, splitting by module was not the ideal approach to removing !placeholder. Marking as duplicate of #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand, since the chosen approach is / will be outlined there, please refer to it for any additional action.
Comment #10
sutharsan commentedRerolling patch for easy migration into single patch at #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.
Changing status for test bot. Do revert status after test.
Comment #11
sutharsan commentedStatus back to 'Closed (duplicate)'. Patch now included in #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.
Comment #12
xjm