Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Follow-up to #2559445: Replace !placeholder with @placeholder in aggregator module
Problem/Motivation
In order to make #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests approachable, we need to break it up into smaller chunks. This issue address !placeholder in the Search module
See #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand for complete motivation on removal of !placeholder
Proposed resolution
Replace !placeholder with @placeholder in the Search module.
core/modules/search/*
Remaining tasks
- Replace !placeholder with @placeholder. Refer to patch in #2506445-85: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests as that patch should have related update
- Ensure tests come back clean
- Manually test the update and post screen shot after patch, review source for any difference in escaping.
User interface changes
Comment | File | Size | Author |
---|---|---|---|
#8 | replace_placeholder-search-2559455-8.patch | 743 bytes | izus |
#2 | replace_placeholder-2559455-2.patch | 14.6 KB | joelpittet |
Comments
Comment #2
joelpittetComment #3
jhodgdonLooks good, thanks!
This patch only affects:
a) Search module main help page
b) Help at top of the Search config page
c) Search results page (excerpts section)
So I tested it at simplytest.me and all of these are fine (all of the links work in the help, too). Good go go!
Comment #4
joelpittetI think this approach may be better instead of lots of patches with the same stuff in them.
#2560783: Replace !placeholder with :placeholder for URLs in hook_help() implementations
This may be the only line needing commit here if the other one gets in first.
Comment #5
jhodgdonLet's make sure this doesn't get committed and break the other patch, since the other issue is being actively discussed and/or committed.
Comment #6
jhodgdonActually I think we should definitely just deal with the non-hook-help parts in this issue, since even the question of whether to do it or not is being discussed on the other issue.
Comment #7
joelpittetFair, we may just close this or repurpose it or something and move that back to the "remaining" child issue because we split them based on size and this one is not meeting that criteria anymore.
Comment #8
izus CreditAttribution: izus commentedHere is the patch with no hook_help parts as they will be addressed in #2560783: Replace !placeholder with :placeholder for URLs in hook_help() implementations
Thanks
Comment #10
izus CreditAttribution: izus commentedtest fails due to file permissions in file migrate component.
that have nothing to do with current patch i think
Comment #13
justAChris CreditAttribution: justAChris as a volunteer commentedAdding related issue, likely cause on fail
Comment #14
jhodgdonYeah but let's not call it Related. It's causing all kinds of tests to fail the same way.
Also please read #7. Once the hook_help() issue is fixed, this one will probably be closed so making another patch or testing it is premature.
Comment #15
jhodgdonComment #16
justAChris CreditAttribution: justAChris as a volunteer commentedClosing this, splitting by module was not the ideal approach to removing !placeholder. Marking as duplicate of #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand, since the chosen approach is / will be outlined there, please refer to it for any additional action.
Comment #18
Sutharsan CreditAttribution: Sutharsan as a volunteer commentedStatus back to 'Closed (duplicate)'. Patch now included in #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.
Comment #19
xjm