Follow-up to #2559445: Replace !placeholder with @placeholder in aggregator module

Problem/Motivation

In order to make #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests approachable, we need to break it up into smaller chunks. This issue address !placeholder in the Help module

See #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand for complete motivation on removal of !placeholder

Proposed resolution

Replace !placeholder with @placeholder in the Help module.

core/modules/help/*

Remaining tasks

  1. Replace !placeholder with @placeholder. Refer to patch in #2506445-85: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests as that patch should have related update
  2. Ensure tests come back clean
  3. Manually test the update and post screen shot after patch, review source for any difference in escaping.

User interface changes

CommentFileSizeAuthor
#2 replace_placeholder-2559453-2.patch10 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Status: Active » Needs review
FileSize
replace_placeholder-2559453-2.patch10 KB
geertvd’s picture

geertvd CreditAttribution: geertvd at XIO commented
Status: Needs review » Closed (duplicate)

Seems like this is completely taken care of in #2560783: Replace !placeholder with :placeholder for URLs in hook_help() implementations

justAChris’s picture

justAChris CreditAttribution: justAChris as a volunteer commented 
--- a/core/modules/help/src/Tests/HelpTest.php
+++ b/core/modules/help/src/Tests/HelpTest.php
@@ -67,7 +67,7 @@ public function testHelp() {
     // Verify that introductory help text exists, goes for 100% module coverage.
     $this->drupalLogin($this->adminUser);
     $this->drupalGet('admin/help');
-    $this->assertRaw(t('For more information, refer to the subjects listed in the Help Topics section or to the <a href="!docs">online documentation</a> and <a href="!support">support</a> pages at <a href="!drupal">drupal.org</a>.', array('!docs' => 'https://www.drupal.org/documentation', '!support' => 'https://www.drupal.org/support', '!drupal' => 'https://www.drupal.org')), 'Help intro text correctly appears.');
+    $this->assertRaw(t('For more information, refer to the subjects listed in the Help Topics section or to the <a href="@docs">online documentation</a> and <a href="@support">support</a> pages at <a href="@drupal">drupal.org</a>.', array('@docs' => 'https://www.drupal.org/documentation', '@support' => 'https://www.drupal.org/support', '@drupal' => 'https://www.drupal.org')), 'Help intro text correctly appears.');

This is not in that hook_help() patch, but @geertvd is correct that this should be closed. The "remaining" patch in #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests can re-absorb this.

geertvd’s picture

geertvd CreditAttribution: geertvd at XIO commented

@justAChris that already seems to be included in #2506445-96: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan as a volunteer commented

Patch now merged into #2506445-140: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Parent issue: #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand »