Follow-up to #2559445: Replace !placeholder with @placeholder in aggregator module

Problem/Motivation

In order to make #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests approachable, we need to break it up into smaller chunks. This issue address !placeholder in the Node module

See #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand for complete motivation on removal of !placeholder

Proposed resolution

Replace !placeholder with @placeholder in the Node module.

core/modules/node/*

Remaining tasks

  1. Replace !placeholder with @placeholder. Refer to patch in #2506445-85: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests as that patch should have related update
  2. Ensure tests come back clean
  3. Manually test the update and post screen shot after patch, review source for any difference in escaping.

User interface changes

CommentFileSizeAuthor
#6 replace_placeholder-2559451-6.patch6.11 KBsutharsan
#3 replace_placeholder-2559451-3.patch8.18 KBgeertvd
#3 interdiff-2559451-2-3.txt5.61 KBgeertvd
#2 replace_placeholder-2559451-2.patch13.79 KBjoelpittet

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new replace_placeholder-2559451-2.patch13.79 KB
geertvd’s picture

geertvd commented
StatusFileSize
new interdiff-2559451-2-3.txt5.61 KB
new replace_placeholder-2559451-3.patch8.18 KB

Removing replacements in hook_help since this is covered in #2560783: Replace !placeholder with :placeholder for URLs in hook_help() implementations

justachris’s picture

justachris commented
Status: Needs review » Postponed

Postponed on determining plan in parent #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand and then analyzing whether this individual issue still makes sense.

justachris’s picture

justachris commented
Status: Postponed » Closed (duplicate)

Closing this, splitting by module was not the ideal approach to removing !placeholder. Marking as duplicate of #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand, since the chosen approach is / will be outlined there, please refer to it for any additional action.

sutharsan’s picture

sutharsan commented
Status: Closed (duplicate) » Needs review
StatusFileSize
new replace_placeholder-2559451-6.patch6.11 KB

Rerolling patch for easy migration into single patch at #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.
Reroll removes changes in NodeTypeRenameConfigImportTest::testConfigurationRename() as the change is already in core. Additionally I removed the changes to NodeEditFormTest::testNodeEdit() as they are already covered by #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.

Changing status for test bot. Do revert status after test.

sutharsan’s picture

sutharsan commented
Status: Needs review » Closed (duplicate)

Status back to 'Closed (duplicate)'. Patch now included in #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.

xjm’s picture

xjm
she/her
Primary language English
commented
Parent issue: #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand »