Problem/Motivation

In order to make #2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests approachable, we need to break it up into smaller chunks. This issue address !placeholder in the Block & Block Content modules

See #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand for complete motivation on removal of !placeholder

Proposed resolution

Replace !placeholder with @placeholder in the Block & Block Content modules.

core/modules/block*

Remaining tasks

  1. Replace !placeholder with @placeholder. Refer to patch in #2506445-85: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests as that patch should have related update
  2. Ensure tests come back clean
  3. Manually test the update and post screen shot after patch, review source for any difference in escaping.

User interface changes

CommentFileSizeAuthor
#7 replace_placeholder-2559447-7.patch7.28 KBgeertvd
#7 interdiff-2559447-5-7.txt11.09 KBgeertvd
#5 replace_placeholder-2559447-5.patch18.38 KBjoelpittet
#5 interdiff.txt776 bytesjoelpittet
#4 replace_placeholder-2559447-4.patch18.99 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Parent issue: #2559445: Replace !placeholder with @placeholder in aggregator module » #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand
Related issues: +#2506445: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Status: Active » Needs review
FileSize
replace_placeholder-2559447-4.patch18.99 KB
joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
FileSize
interdiff.txt776 bytes
replace_placeholder-2559447-5.patch18.38 KB

Will fail because #2559441: Replace !placeholder with @placeholder in views module views block is being tested. (will remove that test because it's isolated)

The last submitted patch, 4: replace_placeholder-2559447-4.patch, failed testing.

geertvd’s picture

geertvd CreditAttribution: geertvd at XIO commented
FileSize
interdiff-2559447-5-7.txt11.09 KB
replace_placeholder-2559447-7.patch7.28 KB

Removing replacements in hook_help since this is covered in #2560783: Replace !placeholder with :placeholder for URLs in hook_help() implementations

justAChris’s picture

justAChris CreditAttribution: justAChris as a volunteer commented
Status: Needs review » Postponed

Postponed on determining plan in parent #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand and then analyzing whether this individual issue still makes sense.

justAChris’s picture

justAChris CreditAttribution: justAChris as a volunteer commented
Status: Postponed » Closed (duplicate)

Closing this, splitting by module was not the ideal approach to removing !placeholder. Marking as duplicate of #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand, since the chosen approach is / will be outlined there, please refer to it for any additional action.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan as a volunteer commented

Patch now merged into #2506445-140: Replace !placeholder with @placeholder in t() and format_string() for non-URLs in tests.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Parent issue: #2506427: [meta] !placeholder causes strings to be escaped and makes the sanitization API harder to understand »