Rename $format and $name to $id and $label in FilterFormat (per @todo)

Thanks! RTBC under condition that the tests pass.

Looks like there are many dependent tests based on this. I think we should break it down into separate issue and make this as meta issue. This way the patch will be easier to review.

I forgot to mention this earlier, but this change needs an upgrade path for sites that already have these configuration entities imported. During the update, use the configuration system to load the configuration (NOT the entity), change the keys, and save it again.

Renamed

Blank patch :)

Blank patch :)

Sorry for posting empty patch previously.

this change needs an upgrade path for sites that already have these configuration entities imported. During the update, use the configuration system to load the configuration (NOT the entity), change the keys, and save it again.

Attaching patch and interdiff.

What I seems in #26, patch and diffs got interchanged. Patch should be diff and diff should be patch. Right ?

No, the patch is only for "FilterFormat.php" file. Interdiff was created for #21 in which "filter.format.plain_text.yml" file was changed which has been reverted in this diff.

Change $format to $id
change $name to $label

Change $format to $id

Reading the last patch I think that something went wrong between #13 and now.
I think we should restart from #13 and find a way to fix the related tests without getting out of scope.

Sorry, I don't think this is a good idea in this stage of releasing the RC. I would move it to 8.1.x.

Agreed.
Thank you all for your work on this issue. Let's reopen it in a few weeks :)

I made these patches last week, but did not get a chance to upload them. I know that this issue is postponed, but I wanted to get the changes into the issue body.

Changes:
- id/label changes in tests (config, install, actual test calls);
- id/label change in the core standard install profile;
- id/label change in module install config;
- id/label change in module schema;
- reverted some incorrect changes of $format to $id, in cases where the $format was actually an entity object.

All of these changes are necessary in order to make the change as filter formats are create using the incorrect keys in all of those settings.

WARNING: don't approve these patches without testing them. There was a case where an exception was thrown related to having both an id key, and an 'edit-form' link. If it occurs during testing, then simply disable that link in the entity definition (annotation.)

That's better! Thank you @jaxxed!
I had a quick look at your patch and it looks quite good.
Some comments follows, for the next person that's going to work on this.

1. +++ b/core/modules/filter/filter.module
   @@ -171,7 +171,7 @@ function filter_get_roles_by_format(FilterFormatInterface $format) {
      foreach (filter_formats() as $format) {
   -    $roles = filter_get_roles_by_format($format);
   +    $roles = filter_get_roles_by_format($id);
   

   $id might be undefined according to the foreach().

2. +++ b/core/modules/filter/src/Tests/FilterHooksTest.php
   @@ -41,22 +41,21 @@ function testFilterHooks() {
   +    $label = $this->randomMachineName();
   +    $format_id = Unicode::strtolower($this->randomMachineName());
   

   Inconsistent. Either use $format_label and $format_id, or $label and $id.

If someone looks at that last patch, this looks like a mistake:

index 46da1f0..7c611f9 100644
--- a/core/modules/filter/filter.module
+++ b/core/modules/filter/filter.module
@@ -171,7 +171,7 @@ function filter_get_roles_by_format(FilterFormatInterface $format) {
 function filter_get_formats_by_role($rid) {
   $formats = array();
   foreach (filter_formats() as $format) {
-    $roles = filter_get_roles_by_format($format);
+    $roles = filter_get_roles_by_format($id);
     if (isset($roles[$rid])) {
       $formats[$format->id()] = $format;
     }

EDIT: this is mentioned in the previous comment, tag you're it.

These are class properties and they must be deprecated. How to do that is explained in the the class properties section of the Drupal Deprecation policy.