Follow-up to #2554965: hook_comment_unpublish is never invoked

Problem/Motivation

hook_comment_publish is called every time the published comment is saved.

Proposed resolution

It should be called only when the status of the comment is changed from unpublished to published.

Remaining tasks

Reviews

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#11 interdiff-2558629-6-11.txt720 bytesrashid_786
#11 2558629-11.patch705 bytesrashid_786
#6 interdiff.txt1.26 KBsumitmadan
#6 hook_comment_publish_to-2558629-6.patch703 bytessumitmadan
#3 hook_comment_publish_to-2558629-3.patch1.12 KBajits

Comments

AjitS created an issue. See original summary.

ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Title: hook_comment publish to be called » hook_comment publish to be called only on the status change and not every time
ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented
Status: Active » Needs review
StatusFileSize
new hook_comment_publish_to-2558629-3.patch1.12 KB
ajits’s picture

ajits
he/him
Primary language Marathi
Location India
commented

Status: Needs review » Needs work

The last submitted patch, 3: hook_comment_publish_to-2558629-3.patch, failed testing.

sumitmadan’s picture

sumitmadan commented
Status: Needs work » Needs review
StatusFileSize
new hook_comment_publish_to-2558629-6.patch703 bytes
new interdiff.txt1.26 KB

Re-rolled the patch. Please do a review.

Status: Needs review » Needs work

The last submitted patch, 6: hook_comment_publish_to-2558629-6.patch, failed testing.

sumitmadan queued 6: hook_comment_publish_to-2558629-6.patch for re-testing.

sumitmadan’s picture

sumitmadan commented
Status: Needs work » Needs review
sumitmadan’s picture

sumitmadan commented
rashid_786’s picture

rashid_786 commented
StatusFileSize
new 2558629-11.patch705 bytes
new interdiff-2558629-6-11.txt720 bytes

Comment line should above the module_invoke_all('comment_publish', $comment);

poker10’s picture

poker10 commented
Status: Needs review » Postponed

Postponing this as of #2554965-27: hook_comment_unpublish is never invoked

poker10’s picture

poker10 commented
Status: Postponed » Closed (won't fix)

The #2554965: hook_comment_unpublish is never invoked is committed. I am going to close this as Won't fix, because it seems to be a big change for this D7 phase. The second reason is that there is a comfort "workaround", as the $comment object in hook_comment_publish()/hook_comment_unpublish contains also the original comment ($comment->original). Therefore any modules relying on this functionality are able to check what status transition it was and take appropriate actions only when needed. Because of this I do not see any particular strong reasons doing such change.

Let's fix only documentation in #1777166: hook_comment_publish() docs are completely wrong. Thanks!