Problem/Motivation

  • Use a entity ref field
  • Use that for vfv
  • enable aggregation in views_field_view

Result, it breaks.

Proposed resolution

The problem is caused by the fieldapi stupidity, let's workaround that.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 2558623-followup-7.patch834 bytesDavid_Rothstein
#2 2558623-2.patch14.83 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Tag1 Consulting commented
Status: Active » Needs review
FileSize
2558623-2.patch14.83 KB

Here is a fix.

Status: Needs review » Needs work

The last submitted patch, 2: 2558623-2.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Tag1 Consulting commented
Status: Needs work » Fixed

Committed it, given that we have some form of test coverage

  • dawehner committed 02be737 on 
    Issue #2558623 by dawehner: Fix query aggregation for fieldapi fields
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented

Do we need that for 8.x?

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Fixed » Needs review
FileSize
2558623-followup-7.patch834 bytes

This caused a syntax error for PHP 5.3 - can we get a quick followup to fix that?

  • jibran committed c10d3ac on 7.x-1.x 
    Issue #2558623 by David_Rothstein: Followup: Fix query aggregation for...
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs review » Fixed

Thanks for the patch @David_Rothstein. Pushed to 7.x-1.x.

Status: Fixed » Needs work

The last submitted patch, 7: 2558623-followup-7.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.