Problem/Motivation

Follow-up to #2214241: Field default markup - removing the divitis

Classy's field--node--uid.html.twig template has a mistake, it's referring to a now-removed field_name_class variable.

This results in output like: field--name-

Proposed resolution

Fix it, it will output field--name-uid

Remaining tasks

  • Patch
  • Review

User interface changes

Potentially some fixes based on this line in /core/modules/node/node.js:

var name = $authorContext.find('.field--name-uid input').val();

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#2 uid_field_missing_data-2558533-2.patch535 bytesstar-szr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Cottser created an issue. See original summary.

star-szr’s picture

star-szr
he/him
Primary language English
CreditAttribution: star-szr as a volunteer commented
Status: Active » Needs review
FileSize
uid_field_missing_data-2558533-2.patch535 bytes

I grepped for field_name_class and this is the last one.

I would tag this with needs tests but I don't think that's a thing for Classy as far as I know. Manual testing may have to suffice, anyone feel free to disagree :)

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost at Skilld commented
Status: Needs review » Reviewed & tested by the community

checked

core/themes/classy/templates/field/field--node--uid.html.twig:25:    'field--name-' ~ field_name_class,
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 62abde4 and pushed to 8.0.x. Thanks!

  • alexpott committed 62abde4 on 8.0.x 
    Issue #2558533 by Cottser: UID field missing data for field--name- class

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.