The filled database dump has a syntax error in it due to several stray $ characters. See #2555183: Fix the filled update tests, they are broken.

CommentFileSizeAuthor
#3 interdiff.txt1.26 KBtim.plunkett
#2 2558063-02.patch411.41 KBjhedstrom

Comments

jhedstrom created an issue. See original summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
StatusFileSize
new 2558063-02.patch411.41 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new interdiff.txt1.26 KB

Here's the diff of the unzipped dumps.
I don't know what else we can do here.

No credit for me please (good, d.o seems to be smart enough to not auto-credit me!)

catch’s picture

catch
he/him
Primary language English
commented

Is this because of a bug in the dump script? If so we should add a follow-up to fix that.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

The export script uses Drupal\Component\Utility\Variable::export(), so perhaps a bug within that? I've seen similar syntax errors in dumps that contain data from key_value_expire table, since some of those IDs will have $ in them unescaped.

stefan.r’s picture

stefan.r commented

RTBC+1, I would assume it was a bug in the dump script since I used that and nothing else to generate the dump.

  • catch committed a2cdc3e on 8.0.x 
    Issue #2558063 by jhedstrom: Fix syntax error in filled database dump
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Opened #2558179: Database dump script produces a dump with syntax errors in it.

Committed/pushed to 8.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.