Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
This seems to be a regression compared to D7
http://example.org/?search=test
http://example.org/?search=Test
The second URL is not correctly identified, it stops at the =
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#14 | 2557021-url-14.patch | 2.21 KB | tim.plunkett |
#8 | url_filter_does_not-2557021-8-interdiff.txt | 1.93 KB | sasanikolic |
#8 | url_filter_does_not-2557021-8.patch | 2.67 KB | sasanikolic |
| |||
#5 | 2557021-filter-5.patch | 2.43 KB | tim.plunkett |
#5 | interdiff.txt | 651 bytes | tim.plunkett |
Comments
Comment #2
BerdirThe only issue that I can find that could have caused this is #1657886: Filter "Convert URLs into links" doesn't support multilingual web addresses.
Comment #3
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedThis should make the test fail.
Comment #5
tim.plunkettYep, @Berdir found the right issue.
Comment #6
BerdirObvious fix is obvious but I think we need the same change for the ending chars too? Just add two more lines with tesT and TesT and it will not work as expected.
Comment #7
BerdirComment #8
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedExtended the test and added the condition for urls ending with capital letters.
Comment #9
BerdirGreat, RTBC if green.
Comment #10
Wim LeersWow, how was this problem not discovered sooner!? This definitely needs a backport to D7 — this code is virtually unchanged from that in D7.
Comment #11
BerdirAs written, this is a regression, it works fine in 7.x, as visible in the issue summary :)
There was exactly one change in that function since 7.x and that broke it, see #2.
However, this fix needs to be included in the backport of that issue.
Comment #12
Wim LeersOh, sorry :(
Comment #13
alexpottThese are out of scope changes. Since we are testing filters I'm loathed to change this without considering whether or not we are losing text coverage - since you are changing both the input and output.
Comment #14
tim.plunkettFair point.
Comment #15
LKS90 CreditAttribution: LKS90 commentedUnrelated changes have been reverted, the patch still applies and passes the tests. RTBC!
Comment #16
alexpottThanks for addressing #13. Committed a3ccfba and pushed to 8.0.x. Thanks!