classTextile.php contains deprecated functions and so it shouldn't be used anymore (I'm testing v4.5.2 from textpattern on github).
The textile implementetion of php-textile on github (v2.5) seems pretty compatible (I've tested it migrating and reviewing thowsand of nodes).
The only issue with that is the $ver attribute is now protected and instead getVersion() should be used.
I suggest:
- Updating the INSTALL.txt suggesting to use the php-textile version, in order to avoid bad situation with deprecated functions.
- Updating textile.install textile_requirements() where $textile->ver is called.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | textile_check_version-2557019-7.patch | 445 bytes | khu |
Comments
Comment #2
gambryComment #3
gambryComment #4
gambryComment #5
indigoxela commented@gambry many thanks for providing this patch
I can confirm that the legacy 2.5 version of PHP-Textile (https://github.com/textile/php-textile/tree/2.5) is compatible with this module and compatible with php 7.2.
Tested with v2.5.5, which was released on 18 Nov 2018.
I can also confirm that the patch #3 fixes the version recognition of this module.
The patch didn't apply, so I added the change manually.
Updating the INSTALL.txt is still pending.
Comment #6
khu commentedRerolled for `7.x-2.0-rc11`
Comment #7
khu commentedUpdated based on #3 to account for prior versions of library.