Inherits beta review from parent issue: #2367749: Remove usage of deprecated UrlGeneratorInterface::generateFromPath()

Problem/Motivation

ImageStyleListBuilder::build() calls UrlGeneratorInterface::generateFromPath() with a path instead of using a route name.

Proposed resolution

Fix using e.g. by finding the route name and changing UrlGeneratorInterface::generateFromPath() to UrlGeneratorInterface::generateFromRoute()

Remaining tasks

User interface changes

n/a

API changes

n/a

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
CommentFileSizeAuthor
#4 fix-generation-url.patch710 byteskarmazzin

Comments

pwolanin created an issue. See original summary.

karmazzin’s picture

karmazzin commented
Assigned: Unassigned » karmazzin
pwolanin’s picture

pwolanin commented
Issue summary: View changes
karmazzin’s picture

karmazzin commented
Status: Active » Needs review
StatusFileSize
new fix-generation-url.patch710 bytes
albertski’s picture

albertski commented

Verified that patch looks good and ran the patch and it was good.

Problem that I am seeing is that I can't get that message to appear. I deleted all my image styles and I wasn't able to get the ''#empty' message to appear. Do you think we should just remove the '#empty' message from here since the EntityListBuilder displays the message "There is no Image style yet."?

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

It looks like this issue adds tests for the #empty text: #2490290: Subclasses of EntityListBuilder incorrectly override the #empty message

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community

Tests of the #empty form element are out of scope here, and are covered in #2490290: Subclasses of EntityListBuilder incorrectly override the #empty message.

This issue does what it says on the tin.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes
karmazzin’s picture

karmazzin commented
Assigned: karmazzin » Unassigned
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Title: Remove usage of UrlGeneratorInterface::generateFromPath() from ImageStyleListBuilder::build() » Remove usage of deprecated UrlGeneratorInterface::generateFromPath() from ImageStyleListBuilder::build()
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed a351a02 and pushed to 8.0.x. Thanks!

  • alexpott committed a351a02 on 8.0.x 
    Issue #2556731 by karmazzin: Remove usage of deprecated...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.