Inherits beta evaluation from parent issue: #2367749: Remove usage of deprecated UrlGeneratorInterface::generateFromPath()

Problem/Motivation

CommentController::renderNewCommentsNodeLinks() calls UrlGeneratorInterface::generateFromPath() with a path instead of using a route name.

Proposed resolution

Fix by changing the method call to generateFromRoute() with a route name and parameters

Remaining tasks

User interface changes

n/a

API changes

n/a

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
CommentFileSizeAuthor
#6 fix-generation-comment-link.patch868 byteskarmazzin

Comments

pwolanin created an issue. See original summary.

pwolanin’s picture

pwolanin commented
Issue tags: +Novice
pwolanin’s picture

pwolanin commented
Issue summary: View changes
pwolanin’s picture

pwolanin commented
Issue summary: View changes
karmazzin’s picture

karmazzin commented
Assigned: Unassigned » karmazzin
karmazzin’s picture

karmazzin commented
Status: Active » Needs review
StatusFileSize
new fix-generation-comment-link.patch868 bytes
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community

Suuuuuuupir eeeeeeeasy. :-)

Thanks!

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes
karmazzin’s picture

karmazzin commented
Assigned: karmazzin » Unassigned
mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Title: Remove usage of UrlGeneratorInterface::generateFromPath() in CommentController::renderNewCommentsNodeLinks() » Remove usage of deprecated UrlGeneratorInterface::generateFromPath() in CommentController::renderNewCommentsNodeLinks()
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 9b8dddd and pushed to 8.0.x. Thanks!

  • alexpott committed 9b8dddd on 8.0.x 
    Issue #2556729 by karmazzin: Remove usage of deprecated...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.