I downloaded this module and noticed there were quite a few pieces of the integration that weren't finished yet.

I am attaching a patch to here that updates it to include these changes.

This work depends on a patch to Commerce Payment to add a default eCheck payment method.

That patch can be found in this issue: #1661548-1: Add ACH / Echeck default form.

Also an updated patch against Commerce Auth.net payments.

Original issue and patch for version 1.1: #1154294-31: Add support for eCheck.Net

Changes added:

  • View on user accounts to manage accounts.
  • Added add, edit, and delete functionality.
  • Updated formatted output of bank and aba numbers to 8 characters.
  • Added the ability to add an account without going through checkout.
  • Updated the settings form in Rules to mimic that of Card on File.
  • Added billing profile to account add form and prefilled with default values.
CommentFileSizeAuthor
#7 commerce_bankonfile-echeck-overhaul-2556193-7.patch101.23 KBpfrilling
#6 overhaul_to_finish_bank-2556193-6.patch91.35 KBanish.a
commerce_bankonfile_updated_code.patch81.73 KBmerauluka

Comments

merauluka created an issue. See original summary.

merauluka’s picture

merauluka commented
Issue summary: View changes
anish_zyxware’s picture

anish_zyxware commented
Assigned: merauluka » anish_zyxware
Status: Active » Needs review
anish_zyxware’s picture

anish_zyxware commented
Status: Needs review » Needs work

This patch doesn't apply. Can you please check?

merauluka’s picture

merauluka commented

I just downloaded the dev copy and reapplied the patched without any issue.

anish.a’s picture

anish.a commented
Status: Needs work » Needs review
StatusFileSize
new overhaul_to_finish_bank-2556193-6.patch91.35 KB

I have reviewed the patch and made some changes regarding commented out code, unused variables, coding standard changes, etc. Please find the attached one.

If you can confirm that you have tested that, I can merge it.

pfrilling’s picture

pfrilling
Location Minster, OH
commented
StatusFileSize
new commerce_bankonfile-echeck-overhaul-2556193-7.patch101.23 KB

We tested the patch you provided and it certainly got the module closer to completion. Good work!

Attached is our patch which integrates the Bank Account on File with Commerce Authorize.net (note: this patch includes anish.a's work from comment #6).

In order for this to work, you'll need to apply the patches located here: https://www.drupal.org/node/2687863

merauluka’s picture

merauluka commented

Hey pfrilling,

Thanks for the newest patch. Did you make yours against my original work or against anish.a's?

pfrilling’s picture

pfrilling
Location Minster, OH
commented

I used anish.a's patch since it was the newest one available. I figured it was the most up to date. The patch I provided also includes anish.a's patch in #6, so it should apply directly to the -dev code.

anish.a’s picture

anish.a commented

Perfect. I will merge the code soon to dev.

anish.a’s picture

anish.a commented
merauluka’s picture

merauluka commented

Awesome. Nice teamwork guys!

  • zyxware committed 9a8b9b8 on 7.x-1.x authored by pfrilling 
    Issue #2556193 by merauluka, anish.a, pfrilling: Overhaul to finish Bank...
zyxware’s picture

zyxware commented
Status: Needs review » Closed (fixed)

Applied the patch. Thanks everyone and great job.

train’s picture

train commented

Patch from #7 appears to be out of sync with dev now? Number of items already applied and a few new ones.

Beta and dev appear to be pretty much the same now.

anish.a’s picture

anish.a commented

We applied the #7 patch and released the dev branch as beta, as its tested.