Problem/Motivation

The indentation on the docblock in \Drupal\Core\Field\Plugin\Field\FieldFormatter\TimestampAgoFormatter for the $request property is incorrect.

Proposed resolution

Fix it.

Remaining tasks

Do it.

User interface changes

None.

API changes

None.

Data model changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it's a simple doc fix.
Issue priority Minor because the indentation is just wrong
Unfrozen changes Unfrozen because it only changes documentation/
Disruption None
CommentFileSizeAuthor
#12 interdiff-8-12.txt903 bytessdstyles
#12 timestampago-2555911-12.patch756 bytessdstyles
#9 timestampago-2555911-8.patch462 bytesamitshah2007
#7 timestampago-2555911-7.patch937 bytesravi.kiran
#3 timestampago-2555911-3.patch1.19 KBamitshah2007

Comments

mpdonadio created an issue. See original summary.

Kuldip Gohil’s picture

Kuldip Gohil commented

It looks fine to me.

amitshah2007’s picture

amitshah2007 commented
StatusFileSize
new timestampago-2555911-3.patch1.19 KB

patch file is attached.

amitshah2007’s picture

amitshah2007 commented
Status: Active » Needs review
sushyl’s picture

sushyl
Location Pune
commented 
+++ b/core/lib/Drupal/Core/Entity/EntityHandlerBase.php
@@ -13,7 +13,8 @@
+ ¶

small nitpick, this will be fixed at the time of committing.It would be good to reroll before getting committed.

meramo’s picture

meramo commented

Rerolled. Applies without issues.

ravi.kiran’s picture

ravi.kiran commented
StatusFileSize
new timestampago-2555911-7.patch937 bytes

patch rerolled.

ankur7213’s picture

ankur7213 commented
Status: Needs review » Needs work

The patch at #7 is not valid as the changes required are not in the scope of this issue.

Patch at #3 should be rerolled with the changes mentioned at #5.

amitshah2007’s picture

amitshah2007 commented
StatusFileSize
new timestampago-2555911-8.patch462 bytes

new patch file generated removing space line.

amitshah2007’s picture

amitshah2007 commented
Status: Needs work » Needs review
mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Status: Needs review » Needs work

Thanks for the effort, but we are still not there.

#3 has the correct change to TimestampAgoFormatter(), but an out of scope change to EntityHandlerBase().

#7 and #9 change EntityHandlerBase(), and don't touch TimestampAgoFormatter().

All we need to do is fix the indentation in TimestampAgoFormatter() at

  /**
    * The current Request object.
    *
    * @var \Symfony\Component\HttpFoundation\Request
    */
  protected $request;

Also, when uploading new patches, you typically include an interdiff to show reviews what has changed between patch versions.

sdstyles’s picture

sdstyles commented
Status: Needs work » Needs review
StatusFileSize
new timestampago-2555911-12.patch756 bytes
new interdiff-8-12.txt903 bytes

Fixed indentation in TimestampAgoFormatter.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
commented
Status: Needs review » Reviewed & tested by the community

#12 looks good to me. Thanks.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 45aca27 and pushed to 8.0.x. Thanks!

  • alexpott committed 45aca27 on 8.0.x 
    Issue #2555911 by amitshah2007, sdstyles, pwlravikiran, mpdonadio:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.