Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2280965: [meta] Remove every SafeMarkup::set() call
Problem/Motivation
ViewsUIController::reportFields() calls SafeMarkup::set() which is meant to be for internal use only.
Proposed resolution
Same as #2501937: Remove SafeMarkup::set in ViewsUIController::reportFields()
Remaining tasks
Write patch
Review patch
Manual testing steps
Do these steps both with HEAD and with the patch applied:
- Clean install of Drupal 8.
- Visit the "Views plugins" page at admin/reports/views-plugins
- Compare the output above in HEAD and with the patch applied. Specifically, review the "Used In" column.
User interface changes
N/A
API changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#2 | 2555809-1.patch | 803 bytes | stefan.r |
#2 | withpatch.png | 48.96 KB | stefan.r |
#2 | head.png | 44.77 KB | stefan.r |
Comments
Comment #2
stefan.r CreditAttribution: stefan.r commentedConfirmed that this creates a
<ul>
based comma list in manual testing and that everything still looks the same:HEAD:
Patch:
Comment #3
dawehnerPerfect!
Comment #4
catchCommitted/pushed to 8.0.x, thanks!