Follow-up to #2280965: [meta] Remove every SafeMarkup::set() call

Problem/Motivation

ViewsUIController::reportFields() calls SafeMarkup::set() which is meant to be for internal use only.

Proposed resolution

Same as #2501937: Remove SafeMarkup::set in ViewsUIController::reportFields()

Remaining tasks

Write patch
Review patch

Manual testing steps

Do these steps both with HEAD and with the patch applied:

  1. Clean install of Drupal 8.
  2. Visit the "Views plugins" page at admin/reports/views-plugins
  3. Compare the output above in HEAD and with the patch applied. Specifically, review the "Used In" column.

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#2 2555809-1.patch803 bytesstefan.r
#2 withpatch.png48.96 KBstefan.r
#2 head.png44.77 KBstefan.r

Comments

stefan.r created an issue. See original summary.

stefan.r’s picture

stefan.r commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new head.png44.77 KB
new withpatch.png48.96 KB
new 2555809-1.patch803 bytes

Confirmed that this creates a <ul> based comma list in manual testing and that everything still looks the same:

HEAD:

Patch:

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 019a759 on 8.0.x 
    Issue #2555809 by stefan.r: Remove SafeMarkup::set in ViewsUIController...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.