I've noticed that the "paypal_payment_ipn" table in the database has a "pid" field described as "The PID of the Payment this IPN is for" but the only call to save an IPN to the database is found in paypal_payment_ipn_post() where $ipn->pid is never set.

This means all IPN's are saved to the database with a default pid of 0.

I haven't actually encountered any problems resulting from this, so I wonder if the pid field might actually be redundant, but I thought I'd mention it anyway in case it needs attention.

CommentFileSizeAuthor
#2 paypal_payment-ipn-pid-2555297-0.patch1012 bytesmorbiD

Comments

morbiD created an issue. See original summary.

morbiD’s picture

morbiD commented
Status: Active » Needs review
StatusFileSize
new paypal_payment-ipn-pid-2555297-0.patch1012 bytes

Here's a patch for this if it needs fixing.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

I've tested this patch and it looks OK. Besides that, this is also part of my new patch: https://www.drupal.org/node/2052361#comment-10444939

  • torotil committed a4a3093 on 7.x-1.x 
    Issue #2550693 by torotil, morbiD: Fix bogus entries in {...
torotil’s picture

torotil commented
Status: Reviewed & tested by the community » Fixed

Committed the fix for #2550693: IPN problem with PayPal's payment review which should also fix this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.