Problem/Motivation

#2554151: Test content/configuration in update database dump proved there is missing schema ... so the missing schema for image_convert is blocking a critical.

Proposed resolution

Add it, also add some basic test coverage

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 interdiff-2-4.txt512 bytesmartin107
#4 2555259-4.patch561 bytesmartin107
#2 2555259-1.patch559 bytesdawehner

Comments

dawehner created an issue. See original summary.

dawehner’s picture

Status: Active » Needs review
Issue tags: +D8 Accelerate
StatusFileSize
new559 bytes

Here is one.

wim leers’s picture

Title: Add config schema for image_conver image effect » Add config schema for image_convert image effect
Issue tags: +Configuration schema
+++ b/core/modules/image/config/schema/image.schema.yml
@@ -35,6 +35,14 @@ image.effect.image_crop:
+image.effect.image_conver:
...
+  label: 'Conver'

s/convert/convert/

martin107’s picture

StatusFileSize
new561 bytes
new512 bytes

Fixed.

gábor hojtsy’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

Needs tests as every other schema fix. Not sure why we broke this out of #2554151: Test content/configuration in update database dump, that one has failing tests due to this missing.

catch’s picture

Priority: Normal » Critical

At minimum this is critical and blocking that issue.

dawehner’s picture

Needs tests as every other schema fix. Not sure why we broke this out of #2554151: Test content/configuration in update database dump, that one has failing tests due to this missing.

Why? Because of babysteps. We need to write the smoke tests anyway for the other issue ... and its block on the entity update one, so would need quite a long time anyway.

jibran’s picture

dawehner’s picture

Issue summary: View changes
Issue tags: -Needs issue summary update

.

jibran’s picture

Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs tests

+1 for the smoke test coverage in the parent issue. I think we are done here.

  • catch committed 089e4f6 on 8.0.x
    Issue #2555259 by martin107, dawehner: Add config schema for...
catch’s picture

Status: Reviewed & tested by the community » Fixed

I opened #2556833: Tests for config schema for image_convert image effect for dedicated test coverage for this, but agree it's better to get the quick fix in to unblock the upgrade path tests given those are completely broken at the moment, where as tests for this are already absent.

Committed/pushed to 8.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.