Problem/Motivation

#2429617: Make D8 2x as fast: Dynamic Page Cache: context-dependent page caching (for *all* users!) uncovered a cache tag we forgot for Forum module's responses: when the vocabulary name is displayed, we need to add the vocabulary entity's cache tag.

Proposed resolution

Fix it.

Remaining tasks

Review.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 forum_vocabulary_cache_tag-2554579-2.patch1.1 KBwim leers
#2 forum_vocabulary_cache_tag-2554579-2-test-only-FAIL.patch585 byteswim leers

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
Issue tags: +Quickfix
StatusFileSize
new forum_vocabulary_cache_tag-2554579-2-test-only-FAIL.patch585 bytes
new forum_vocabulary_cache_tag-2554579-2.patch1.1 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +D8 cacheability

The last submitted patch, 2: forum_vocabulary_cache_tag-2554579-2-test-only-FAIL.patch, failed testing.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

Trivial fix. Thanks for the test coverage.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 3aa2cbb on 8.0.x 
    Issue #2554579 by Wim Leers: Forum index response is missing the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.