This is a possible regression:

Running hostmaster-install with the --http_port=8080 flag has no effect. The server is configured to use the default port 80.

CommentFileSizeAuthor
#4 hostmaster_install_ports-2554087-4.patch768 bytesm.stenta

Comments

m.stenta created an issue. See original summary.

m.stenta’s picture

m.stenta
he/him
Primary language English
commented
Title: Regression: » Regression: hostmaster-install --http_port=8080
cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented

For posterity:

[12:26:09]  < mstenta>	I created an issue for the --http_port regression: https://www.drupal.org/node/2554087
[12:26:11]  < hefring>	https://www.drupal.org/node/2554087 => Regression: hostmaster-install --http_port=8080 [#2554087] => 2 comments, 1 IRC mention
[12:26:54]  < mstenta>	If anyone has any ideas... I'm digging into it... but it's been a while since I've been in the provision code, so I'm rusty.
[13:06:55]  <@cweagans>	mstenta: looks like provision is handling the argument properly, but the hostmaster profile itself is not respecting what's in the context for the web server.
[13:07:17]  <@cweagans>	mstenta: http://cgit.drupalcode.org/hostmaster/tree/hostmaster.install#n53
[13:07:39]  <@cweagans>	mstenta: ditto with the database port
[13:07:58]  <@cweagans>	(line 77 - same file)
m.stenta’s picture

m.stenta
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new hostmaster_install_ports-2554087-4.patch768 bytes

Attached is a patch that fixes the http_port and db_port variables in hostmaster.install.

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Assigned: Unassigned » gboudrias
Status: Needs review » Reviewed & tested by the community
Parent issue: » #2547235: [meta] 3.1 release (bugfix/patches)

LGTM. Assigning to gboudrias as he might have time to take a final look before the 3.1 release.

helmo’s picture

helmo commented
Status: Reviewed & tested by the community » Fixed

Committed, http://cgit.drupalcode.org/hostmaster/commit/?id=2df5426ac6b76b98aaba332...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gboudrias’s picture

gboudrias commented
Issue tags: +Aegir 3.2