Problem/Motivation

Follow-up from #1020574: Add contextual link to edit feed to aggregator blocks
At the moment FeedInterface has a getLastModified() method. This could be removed and FeedInterface could extend EntityChangedInterface.
This is more consistent to what other entities are doing.

Proposed resolution

Remove the getLastModified() from FeedInterface and replace all it's occurrences with getChangedTime() from the EntityChangedInterface

Remaining tasks

Do it, make sure all tests pass.

CommentFileSizeAuthor
#2 feedinterface_should-2554079-2.patch3.88 KBgeertvd

Comments

geertvd created an issue. See original summary.

geertvd’s picture

geertvd commented
Status: Active » Needs review
StatusFileSize
new feedinterface_should-2554079-2.patch3.88 KB

Let's see if this breaks anything

ParisLiakos’s picture

ParisLiakos commented

i am not sure this is correct.
(get|set)LastModified() is about when the external's feed content changed and not when the Drupal entity changed.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Oh, heh, I think #3 is correct. Sorry about that.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Closed (works as designed)

Apologies, @geertvd!