I opened the translation interface to update my website translations and found the button checkbox "Clean up left over strings." has a broken styling.

check attached screenshot.

the issue is that any checkbox with delete, remove ids was styled to be red and removed the border on hover, so when u hover over the checkbox or the its label it will be shifted up 1 px, and the margins is wrong here.

CommentFileSizeAuthor
#2 broken_style_for_red_checkboxes-2553985-2.patch1.34 KBmqanneh
#2 after.png24.03 KBmqanneh
before.png42.73 KBmqanneh

Comments

mqanneh created an issue. See original summary.

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Needs work » Needs review
StatusFileSize
new after.png24.03 KB
new broken_style_for_red_checkboxes-2553985-2.patch1.34 KB

Attached patch fixed the issue.

check before and after screenshots.

ANDiTKO’s picture

ANDiTKO commented
Priority: Major » Normal
Status: Needs review » Closed (fixed)

Thank you @mqanneh !

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented

Thank you @ANDiTKO for committing my patch without giving me a contribution.

Why my patch is committed under your username?

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Closed (fixed) » Active

Re open untill webmasters check it.

My patch was committed under another username.

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented

@ANDiTKO

This patch was created by me and you changed the author from mqanneh to your username when u committed it.
http://cgit.drupalcode.org/adminimal_theme/commit/?id=2dc51ffff6df31a0e5...

check this
https://www.drupal.org/node/2403651#comment-9742833

git revert 2dc51ffff6df31a0e53c458d8e926ee4a4df69ad
then commit again with --author option
git commit -m 'Issue #2553985 by mqanneh: Broken style for checkbox with red style' --author="mqanneh "

ANDiTKO’s picture

ANDiTKO commented
Status: Active » Closed (fixed)

I blindly applied and committed your patch and it took me 2 seconds to understand that your code will mess up other page styling.
For example, apply your patch and visit the "admin/modules/uninstall". As you can see the "Uninstall" button is messed up. You have removed the padding and other css properties to all the "Red" buttons.

As far as the credits, sorry. It was not intentional. Ive recently switched to the github GUI app that dosent have much options. But its very easy and pleasing to use. I will keep that in mind for next patches. But i wont apply your patch because it causes styling problems to other elements.

mqanneh’s picture

mqanneh
he/him
Primary language English
Location Amman
commented
Status: Closed (fixed) » Active

I'll fix the patch by adding new css targeting only the checkboxes and re-submit it.

ANDiTKO’s picture

ANDiTKO commented

i fixed it already in my dev. i will commit it soon (doing some cool changes to the buttons in next version).

Thanks for the contribution and sorry for the patch credit ;) (if you see my commit message history, you will see that i always try to give credit to contributors i thought drupal.org is doing this automatically when you reference the issue id and the @Username)

  • ANDiTKO committed ce1b3f5 on 7.x-1.x 
    Checkbox fixes and Button click styling

* Issue #2553985 by mqanneh,...
ANDiTKO’s picture

ANDiTKO commented
Status: Active » Closed (fixed)