Problem/Motivation

LanguageListBuilder::__construct phpdoc references EntityListController, but this was renamed long ago.

Proposed resolution

Fix phpdoc so it is accurate.

Remaining tasks

None. (Patched and Reviewed)

User interface changes

None.

API changes

None.

Data model changes

None.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because ...
Issue priority Normal
Unfrozen changes Unfrozen because it only changes documentation.
CommentFileSizeAuthor
#6 fix-2553719-6.patch580 bytesdschenk
#3 fix-2553719-3.patch629 bytesdschenk

Comments

penyaskito created an issue. See original summary.

dschenk’s picture

dschenk commented

I'm going to fix this while sprinting in Barcelona.

dschenk’s picture

dschenk commented
Status: Active » Needs review
StatusFileSize
new fix-2553719-3.patch629 bytes

Status: Needs review » Needs work

The last submitted patch, 3: fix-2553719-3.patch, failed testing.

The last submitted patch, 3: fix-2553719-3.patch, failed testing.

dschenk’s picture

dschenk commented
StatusFileSize
new fix-2553719-6.patch580 bytes

Uploading new patch. The last one was malformed by PHPStorm. This time I created it directly in the command line and git.

dschenk’s picture

dschenk commented
Status: Needs work » Needs review
lucastockmann’s picture

lucastockmann commented
Status: Needs review » Reviewed & tested by the community

Patch (https://www.drupal.org/files/issues/fix-2553719-6.patch) applied fine, and new documentation is correct. So lets get this into core.

sutharsan’s picture

sutharsan commented

I mentored @dschenk and @axooh while working on this issue. +1 for RTBC

axooh’s picture

axooh commented
Issue summary: View changes

Updated the issue summary (remaining tasks). I worked together with @dschenk an this issue.

  • webchick committed 38a0e06 on 8.0.x 
    Issue #2553719 by dschenk, penyaskito, lucastockmann, Sutharsan, axooh:...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed LIVE at DrupalCon Barelona :D

hussainweb’s picture

hussainweb
Primary language English
commented

@webchick, that's Barcelona. ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.