Problem/Motivation

See: #2489460: [Meta] Move module.theme.css files to Classy or Seven

Proposed resolution

Move the CSS file to classy
Rename the file to remove the .theme. extension
Alter the system.base library so the CSS file is loaded with a similar weight to before

Remaining tasks

Test steps

Check that the CSS file was deleted from the module and added to Classy
Check that the references to that CSS file removed from the system module
Check that the CSS file is being loaded in the correct places in Classy
Check that there are no HTML classes in the module that relies on the theme CSS

User interface changes

None for Classy, Stark will be more Stark

API changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because coding standards
Issue priority Not critical because coding standards
Unfrozen changes Unfrozen because it only changes markup
CommentFileSizeAuthor
#6 Screenshot 2015-08-27 18.43.00.jpg447.65 KBLewisNyman
#6 Screenshot 2015-08-27 18.42.26.jpg448.23 KBLewisNyman
#6 Screenshot 2015-08-27 18.42.12.jpg424.54 KBLewisNyman
#6 move_system-2553447-6.patch2.15 KBLewisNyman
#5 move_system-2553447-5.patch2.28 KBdavidhernandez
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mdrummond created an issue. See original summary.

RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray commented
Status: Needs review » Active
RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray commented
Parent issue: #2549563: Move system action-links.theme.css, breadcrumb.theme.css, and button.theme.css to Classy » #2489460: [Meta] Move module.theme.css files to Classy or Seven
RainbowArray’s picture

RainbowArray
she/her
Primary language English
Location Twin Cities, Minnesota
CreditAttribution: RainbowArray commented
Issue summary: View changes
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez as a volunteer commented
Status: Active » Needs review
FileSize
move_system-2553447-5.patch2.28 KB

I used the weight and component instead of theme simply because Seven and Bartik heavily use component and have very little use of theme. This gets it about high up in the order without using base.

There shouldn't be visual regressions. This file just has the CSS to make the pink background when a node is unpublished.

LewisNyman’s picture

LewisNyman
he/him
CreditAttribution: LewisNyman at Wunder commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
move_system-2553447-6.patch2.15 KB
Screenshot 2015-08-27 18.42.12.jpg424.54 KB
Screenshot 2015-08-27 18.42.26.jpg448.23 KB
Screenshot 2015-08-27 18.43.00.jpg447.65 KB

Here's the reroll after #977844: Remove the 'every_page' option for CSS/JS assets: it is confusing, even damaging

I tested the patch and I've attached screenshots to show Bartik, Classy, and Stark after the patch. It's a pretty simple patch.

  • webchick committed 6466caa on 8.0.x 
    Issue #2553447 by LewisNyman, davidhernandez, mdrummond: Move system...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick at Acquia commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.