See: #2489460: [Meta] Move module.theme.css files to Classy or Seven
Move the CSS file to classy
Rename the file to remove the .theme. extension
Alter the system.base library so the CSS file is loaded with a similar weight to before
Check that the CSS file was deleted from the module and added to Classy
Check that the references to that CSS file removed from the system module
Check that the CSS file is being loaded in the correct places in Classy
Check that there are no HTML classes in the module that relies on the theme CSS
None for Classy, Stark will be more Stark
None
| Issue category | Task because coding standards |
|---|---|
| Issue priority | Not critical because coding standards |
| Unfrozen changes | Unfrozen because it only changes markup |
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Screenshot 2015-08-27 18.43.00.jpg | 447.65 KB | lewisnyman |
| #6 | Screenshot 2015-08-27 18.42.26.jpg | 448.23 KB | lewisnyman |
| #6 | Screenshot 2015-08-27 18.42.12.jpg | 424.54 KB | lewisnyman |
| #6 | move_system-2553447-6.patch | 2.15 KB | lewisnyman |
Comments
Comment #2
rainbowarrayComment #3
rainbowarrayComment #4
rainbowarrayComment #5
davidhernandezI used the weight and component instead of theme simply because Seven and Bartik heavily use component and have very little use of theme. This gets it about high up in the order without using base.
There shouldn't be visual regressions. This file just has the CSS to make the pink background when a node is unpublished.
Comment #6
lewisnymanHere's the reroll after #977844: Remove the 'every_page' option for CSS/JS assets: it is confusing, even damaging
I tested the patch and I've attached screenshots to show Bartik, Classy, and Stark after the patch. It's a pretty simple patch.
Comment #8
webchickCommitted and pushed to 8.0.x. Thanks!