Problem/Motivation

When installing a new test store with 7.x-2.27, there are no products anymore with more than one variation. Up to 7.x-2.26 there were multiple products with more than one variation (e.g. the Commerce Guys USB Key).

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 commerce_kickstart-test_store_no_variations-2553365-6.patch637 bytesTimRutherford
#4 new-variation-shows-up.png336.33 KBTimRutherford
#4 add-new-variation.png103.58 KBTimRutherford
#4 all-default-variations.png70.95 KBTimRutherford
#4 no-variations.png330.94 KBTimRutherford
capacity-chooser-missing-in-27.png296.71 KBznerol
capacity-chooser-present-in-26.png287.47 KBznerol

Comments

znerol created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue tags: +sprint, +Needs tests

Good catch. This might have happened from Migrate upgrade. We'll need some Behat tests for this, too. We have tests using the default imported items, but perhaps nothing changes attributes.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Priority: Normal » Major
Issue tags: +Commerce Sprint
TimRutherford’s picture

TimRutherford commented
Version: 7.x-2.27 » 7.x-2.31
StatusFileSize
new no-variations.png330.94 KB
new all-default-variations.png70.95 KB
new add-new-variation.png103.58 KB
new new-variation-shows-up.png336.33 KB

So I looked into this a bit and found out a few things.

No variations show

Even in the latest 7.x-2.31 version this still seems to be a problem.

All the default variations

The variations are still created/imported but they don't seem to be linked to the same product.

Adding a new variation manually

After adding a new variation manually to the existing product,

New variation shows in chooser

the variation chooser shows on the page and the new variation can be selected.

So it seems to be an issue purely with the automatic importing of all the test products and variations.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

TimRutherford, thanks! A few months back we updated to the latest version of Migrate. I have a feeling the issue is in the migrate class definitions if you'd care to take a peak. Or if you want to jam on this feel free to ping me in IRC!

TimRutherford’s picture

TimRutherford commented
Version: 7.x-2.31 » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new commerce_kickstart-test_store_no_variations-2553365-6.patch637 bytes

So after digging around the code for some time, I finally found the problem. About 2-3 years ago a patch was applied (commerce_products_source_migration-1931302-2.patch) from this Commerce Migrate issue, at the time it fixed a similar issue. I tested removing the patch and it does instead fix the problem, I'm just hoping it wont cause something else to break as well.

Here's the patch that removes commerce_products_source_migration-1931302-2.patch from the make file.

  • mglaman committed a13f40d on 7.x-2.x authored by TimRutherford 
    Issue #2553365 by TimRutherford: Test store does not have any product...
  • mglaman committed c385df9 on 7.x-2.x
    Merge pull request #170 from mglaman/2553365

Issue #2553365 by...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.