This is a follow up to #2304461: KernelTestBaseTNG™ because it hampers/blocks progress in #2456477: Convert deprecated \Drupal\simpletest\KernelTestBase tests to KernelTestBaseNG

Steps to expose this bug :-

Start the conversion of core/modules/config/src/Tests/Storage/ConfigStorageTestBase.php
by doing this:

-use Drupal\simpletest\KernelTestBase;
+use Drupal\KernelTests\KernelTestBase;

The bug can be seems now, after running CachedStorageTests ( which extends ConfigStorageTestBase ).

Reading from https://secure.php.net/manual/en/function.trigger-error.php, only E_USER_* constants may be used when invoking trigger_error()

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because is hides the deprecated warnings which are useful in debugging.
Issue priority Normal - debugging is harder than it should be for lots of test conversions in progress.
Unfrozen changes Unfrozen because it only changes tests.
Disruption Minimal
CommentFileSizeAuthor
#5 2553245-3.patch1.38 KBstefan.r
#5 interdiff-1-3.txt716 bytesstefan.r
#3 2553245-2.patch35.07 KBstefan.r
trigger-0.patch857 bytesmartin107

Comments

martin107 created an issue. See original summary.

martin107’s picture

martin107 commented
Title: KernelTestBase uses an undefined constant. » KernelTestBase uses an inappropriate constant in calls to trigger_error

When I say undefined, that is not strictly true... it is a value inappropiate to trigger_error calls

stefan.r’s picture

stefan.r commented
StatusFileSize
new 2553245-2.patch35.07 KB

So let's fix it everywhere? :)

Status: Needs review » Needs work

The last submitted patch, 3: 2553245-2.patch, failed testing.

stefan.r’s picture

stefan.r commented
Title: KernelTestBase uses an inappropriate constant in calls to trigger_error » KernelTestBase uses a disallowed constant in calls to trigger_error
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new interdiff-1-3.txt716 bytes
new 2553245-3.patch1.38 KB
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Lol yeah

martin107’s picture

martin107 commented
Issue summary: View changes

Just greasing the wheels by adding beta evaluation.

and making the issue summary easier to read.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d3d9300 and pushed to 8.0.x. Thanks!

  • alexpott committed d3d9300 on 8.0.x 
    Issue #2553245 by stefan.r, martin107: KernelTestBase uses a disallowed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.