Problem/Motivation

Upstream version of Radix in use by OA Radix has a performance regression. This bug has been fixed for some time in Radix but that fix has not been backported to Atrium. This reduction was originally reported here as 1 second, but the upstream report calls it 10 seconds.

Proposed resolution

Include the patch originally committed to Radix to OA Radix

Remaining tasks

Review & Commit

User interface changes

None

API changes

None

Data model changes

None

Original Report

The actual version 7.x-3.x [38eb2d99] is out of date. During some performance profiling i recognized that the radix version coming with openatrium calls drupal_get_path('module', 'field_slideshow') without checking if the module exists. This makes drupal calling file_scan_directory so radix_js_alter takes up to 1 second on my setup.

Regards,
Leo

Comments

leo_g created an issue. See original summary.

Grayside’s picture

In my local environment I find the impact closer to 8 seconds, for lack of the field_slideshow module. I've added an issue link where this problem was originally fixed.

Grayside’s picture

Issue summary: View changes
StatusFileSize
new764 bytes

After discussion with @mpotter, a simple Radix update will not work. After double verifying, it seems like the specific patch in the issue I linked earlier is still compatible with the version of Radix in use by OA Radix. Here's a patch to amend the OA Radix makefile with that patch.

Grayside’s picture

Title: update radix version in makefile » Backport performance bug fix from Radix
Issue tags: +Performance
Grayside’s picture

Status: Active » Needs review
mpotter’s picture

Status: Needs review » Fixed

Committed to 86e2cc5.

  • mpotter committed 86e2cc5 on 7.x-3.x authored by Grayside
    Issue #2552787 by Grayside: Backport performance bug fix from Radix
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.