The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
PostgreSQL supports GREATEST() since 8.1 and CONCAT() since 9.1, we don't need to provide user-space implementations for them anymore.
Proposed resolution
Remove them.
Remaining tasks
Review / commit.
User interface changes
Nope.
API changes
Nope.
Data model changes
Nope.
Beta phase evaluation
| Issue category | Task because nothing is broken. |
|---|---|
| Prioritized changes | The main goal of this issue is removing dead code from the PostgreSQL driver. |
| Disruption | None. |
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2552769.patch | 2.25 KB | amateescu |
Comments
Comment #2
amateescu commentedAnd a patch.
Comment #3
mradcliffeI ran out of time for review.
Will this need an upgrade path to remove the functions?
Comment #4
amateescu commentedGiven that D8 was quite broken on Postgres until a few weeks ago, I seriously doubt that there are live D8 sites out there using this driver. Also, having the custom functions there doesn't really do any harm, so I don't think we need an upgrade path for this.
Comment #5
pwolanin commentedRemoving this cruft looks like a win to me.
Comment #6
alexpottLess custom code for Postgres is a good thing. Committed ab748bf and pushed to 8.0.x. Thanks!
Thanks for the beta evaluation. Removing dead code is permitted during beta.
Comment #8
pwolanin commentedWe should probably port to 7.x to not create these on 9.1 and later?
Comment #14
amateescu commentedIf anyone really wants to port this patch to 7.x at this point, it can happen in a new issue :)