Problem/Motivation

PostgreSQL supports GREATEST() since 8.1 and CONCAT() since 9.1, we don't need to provide user-space implementations for them anymore.

Proposed resolution

Remove them.

Remaining tasks

Review / commit.

User interface changes

Nope.

API changes

Nope.

Data model changes

Nope.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because nothing is broken.
Prioritized changes The main goal of this issue is removing dead code from the PostgreSQL driver.
Disruption None.
CommentFileSizeAuthor
#2 2552769.patch2.25 KBamateescu

Comments

amateescu created an issue. See original summary.

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 2552769.patch2.25 KB

And a patch.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

I ran out of time for review.

Will this need an upgrade path to remove the functions?

amateescu’s picture

amateescu commented

Will this need an upgrade path to remove the functions?

Given that D8 was quite broken on Postgres until a few weeks ago, I seriously doubt that there are live D8 sites out there using this driver. Also, having the custom functions there doesn't really do any harm, so I don't think we need an upgrade path for this.

pwolanin’s picture

pwolanin commented
Status: Needs review » Reviewed & tested by the community

Removing this cruft looks like a win to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Less custom code for Postgres is a good thing. Committed ab748bf and pushed to 8.0.x. Thanks!

Thanks for the beta evaluation. Removing dead code is permitted during beta.

  • alexpott committed ab748bf on 8.0.x 
    Issue #2552769 by amateescu: Remove outdated custom functions for...
pwolanin’s picture

pwolanin commented
Version: 8.0.x-dev » 7.x-dev
Status: Fixed » Patch (to be ported)

We should probably port to 7.x to not create these on 9.1 and later?

  • alexpott committed ab748bf on 8.1.x 
    Issue #2552769 by amateescu: Remove outdated custom functions for...

  • alexpott committed ab748bf on 8.3.x 
    Issue #2552769 by amateescu: Remove outdated custom functions for...

  • alexpott committed ab748bf on 8.3.x 
    Issue #2552769 by amateescu: Remove outdated custom functions for...

  • alexpott committed ab748bf on 8.4.x 
    Issue #2552769 by amateescu: Remove outdated custom functions for...

  • alexpott committed ab748bf on 8.4.x 
    Issue #2552769 by amateescu: Remove outdated custom functions for...
amateescu’s picture

amateescu commented
Version: 7.x-dev » 8.0.x-dev
Status: Patch (to be ported) » Fixed

If anyone really wants to port this patch to 7.x at this point, it can happen in a new issue :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.