Problem/Motivation

The following two statements are unnecessary in BlockContentTypeForm.php. Since they aren't being used in the code, they should be removed.

use Drupal\field\Entity\FieldConfig;
use Drupal\field\Entity\FieldStorageConfig;

Proposed resolution

Remove the two statements.

Remaining tasks

  • Remove use statements
  • Complete issue summary
  • Add beta eval

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#3 unused_use_statements-2552219-3.patch565 bytesscreon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner created an issue. See original summary.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented
Issue summary: View changes

.

screon’s picture

screon CreditAttribution: screon commented
FileSize
unused_use_statements-2552219-3.patch565 bytes 
use Drupal\field\Entity\FieldConfig;
use Drupal\field\Entity\FieldStorageConfig;

These were indeed unused in the file. Here's a patch that removes them.

screon’s picture

screon CreditAttribution: screon commented
Issue summary: View changes
screon’s picture

screon CreditAttribution: screon commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: unused_use_statements-2552219-3.patch, failed testing.

Status: Needs work » Needs review

screon queued 3: unused_use_statements-2552219-3.patch for re-testing.

stefan.r’s picture

stefan.r CreditAttribution: stefan.r commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

This is green and there are no further unused use statements in that file, so RTBC!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner as a volunteer and at Chapter Three commented

+1

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

This tidy up has been postponed till the RC stage where we're going to automated one big clean up. However considering this is @screon's first patch I'm going to commit, but this is not a license to file an issue per file with missing use statements. Committed 15366a6 and pushed to 8.0.x. Thanks!

  • alexpott committed 15366a6 on 8.0.x 
    Issue #2552219 by screon: Unused use statements in \Drupal\block_content...
screon’s picture

screon CreditAttribution: screon commented

Thank you for your flexibility!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.