Problem/Motivation

As per #2464427-156: Replace CacheablePluginInterface with CacheableDependencyInterface it is use less for UpdatePathTestBaseTest::testDatabaseLoaded() to check the frontpage. Schema version should be enough.

Proposed resolution

Remove the frontpage asserts

Remaining tasks

Review
Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#3 don_t_access_frontpage-2551579-3.patch896 bytesgeertvd
fix-UpdatePathTestBaseTest-testDatabaseLoaded.patch1015 bytesjibran

Comments

jibran created an issue. See original summary.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Don't access frontpage in UpdatePathTestBaseTest::testDatabaseLoaded() » Don't access frontpage before running updates in UpdatePathTestBaseTest::testDatabaseLoaded()
Status: Needs review » Needs work

We need to run updates before accessing the frontpage, then we should be fine. That's what we need to fix :)

geertvd’s picture

geertvd commented
Status: Needs work » Needs review
StatusFileSize
new don_t_access_frontpage-2551579-3.patch896 bytes

Something like this then?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Yes, that's exactly what I think we should do.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Test only change permitted in beta. Committed 0d25892 and pushed to 8.0.x. Thanks!

  • alexpott committed 0d25892 on 8.0.x 
    Issue #2551579 by jibran, geertvd: Don't access frontpage before running...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.