Editor.module already uses BaseCommand, and we're finding in contrib it's handy to use. I think the fact that it's namespaced under quickedit made me realize it wasn't there. But having it under \Drupal\Core\Ajax makes it seem like something that can be re-used, which it should be!

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because would improve DX slightly.
Issue priority Major because ... Critical/Not critical because ...
Disruption Only affects an internal D8 core Quick Edit implementation detail, so no actual disruption.
CommentFileSizeAuthor
#2 2551105-move-basecommand-to-core-ajax.patch3.26 KBdave reid

Comments

Dave Reid created an issue. See original summary.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2551105-move-basecommand-to-core-ajax.patch3.26 KB
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +DX (Developer Experience)

Makes sense!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Priority: Normal » Minor
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I see this as an API broadening and sensible - I guess some contrib could break if they were depending on this - but then they'd be depending on quickedit which seems unlikely.

Committed 887b1e4 and pushed to 8.0.x. Thanks!

diff --git a/core/lib/Drupal/Core/Ajax/BaseCommand.php b/core/lib/Drupal/Core/Ajax/BaseCommand.php
index 0b69458..86d694d 100644
--- a/core/lib/Drupal/Core/Ajax/BaseCommand.php
+++ b/core/lib/Drupal/Core/Ajax/BaseCommand.php
@@ -2,7 +2,7 @@
 
 /**
  * @file
- * Contains \Drupal\quickedit\Ajax\BaseCommand.
+ * Contains \Drupal\Core\Ajax\BaseCommand.
  */
 
 namespace Drupal\Core\Ajax;

Fixed on commit.

  • alexpott committed 887b1e4 on 8.0.x 
    Issue #2551105 by Dave Reid: BaseCommand should not be in the quickedit...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

+1 to #5's reasoning.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.