Simplify the switch-case in system_tokens() for the date format definitions (short, medium, long)

CommentFileSizeAuthor
#2 drupal-2551047-2-system-token-switch.patch1.28 KBsweetchuck

Comments

Sweetchuck created an issue. See original summary.

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented
Status: Active » Needs review
StatusFileSize
new drupal-2551047-2-system-token-switch.patch1.28 KB
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: drupal-2551047-2-system-token-switch.patch, failed testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Fails with the following in updatepathtestbase:

Link Continue does not exist on http://ec2-54-191-113-78.us-west-2.compute.amazonaws.com/checkout/update.php
Link Apply pending updates does not exist on http://ec2-54-191-113-78.us-west-2.compute.amazonaws.com/checkout/update.php	
No schema for system.filter

Certainly not related.

Status: Needs work » Needs review

Gábor Hojtsy queued 2: drupal-2551047-2-system-token-switch.patch for re-testing.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

BTW this makes fixes like #2529182: Not all node, taxonomy entity tokens are multilingual aware easier to do cleanly without arbitrary code move-arounds.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

In general we shouldn't be change like this, but, I'm committing this under the committer discretion proviso considering what @Gábor Hojtsy said in the previous comment - if this makes other fixes cleaner - then so be it. There is no disruption from making this change. Committed 45ce123 and pushed to 8.0.x. Thanks!

  • alexpott committed 45ce123 on 8.0.x 
    Issue #2551047 by Sweetchuck: Simplify the switch-case in system_tokens...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.