Amazon S3 allows the developer to provide additional headers when uploading content to a bucket. In high traffic sites which use CDN to distribute the content stored in S3 its necesary to configure the max-age cache-control header to be able to configure when an asset should be expired. We have added the option to configure the max-age for a bucket in the configuration screen. We are providing a patch for this feature in case the mainteiner would like to add it to the S3 serice.

CommentFileSizeAuthor
#10 storage_api-allow_configuration_of_max_age-2550969-10.patch1.81 KBmarcosdmyr
#5 storage_api-allow_configuration_of_max_age-2550969-1.png73.41 KBmarcosdmyr
#3 storage_api-allow_configuration_of_max_age-2550969-1.png71.99 KBmarcosdmyr
#3 storage_api-allow_configuration_of_max_age-2550969-1.patch1.97 KBmarcosdmyr

Comments

marcosdmyr created an issue. See original summary.

perignon’s picture

perignon commented

I never turn a patch down if it adds value or betters the module!

marcosdmyr’s picture

marcosdmyr commented
StatusFileSize
new storage_api-allow_configuration_of_max_age-2550969-1.patch1.97 KB
new storage_api-allow_configuration_of_max_age-2550969-1.png71.99 KB
marcosdmyr’s picture

marcosdmyr commented
marcosdmyr’s picture

marcosdmyr commented
StatusFileSize
new storage_api-allow_configuration_of_max_age-2550969-1.png73.41 KB
marcosdmyr’s picture

marcosdmyr commented
Issue tags: -max-age cache-control header +max-age cache-control header s3
perignon’s picture

perignon commented
Assigned: marcosdmyr » perignon
Status: Active » Needs review

Thanks for the patch. I will get it reviewed in my next cycle of work on the module.

Status: Needs review » Needs work

The last submitted patch, 3: storage_api-allow_configuration_of_max_age-2550969-1.patch, failed testing.

marcosdmyr’s picture

marcosdmyr commented
Assigned: perignon » marcosdmyr
marcosdmyr’s picture

marcosdmyr commented
StatusFileSize
new storage_api-allow_configuration_of_max_age-2550969-10.patch1.81 KB
marcosdmyr’s picture

marcosdmyr commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 10: storage_api-allow_configuration_of_max_age-2550969-10.patch, failed testing.

perignon’s picture

perignon commented

I see lots of small patches fail. I will look into it manually.

  • Perignon committed a50db30 on 7.x-1.x 
    git commit -m 'Issue #2550969 by marcosdmyr: Allow configuration of max-...
perignon’s picture

perignon commented
Status: Needs work » Fixed
perignon’s picture

perignon commented

Thanks for the contributions!

marcosdmyr’s picture

marcosdmyr commented

Thanks to you for revising the patch Perignon!

perignon’s picture

perignon commented

Yeah just some minor clean ups. #title should be untranslated text to keep from calling t() twice, core does it for you :-D

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.